Create a non-generic Il2CppArrayBase class#126
Conversation
|
Should https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1000 |
Now that I think about it some more, this should be a future pull request because it has implications on the generator, which I significantly changed in #124. |
ManlyMarco
left a comment
There was a problem hiding this comment.
Is Il2CppArrayBase or are classes inheriting it directly accessed by any plugin code? If yes, this looks like a binary compatibility break.
Plugins can and do access these classes. My pull request has two breaking changes:
|
|
I'm not sure how much breaking changes matter because my ultimate goal is to make lots of breaking changes. I want to do a proper C# type system with real interfaces and virtual methods. Porting to AsmResolver is just a first step towards that goal. |
db4f65d to
59e4614
Compare
Done |
4e04eb2 to
1262b53
Compare
This will be important for unstripping
ldlen.