Skip to content

Port generator to use AsmResolver#124

Merged
ManlyMarco merged 36 commits intoBepInEx:masterfrom
ds5678:asmresolver-port
Sep 8, 2024
Merged

Port generator to use AsmResolver#124
ManlyMarco merged 36 commits intoBepInEx:masterfrom
ds5678:asmresolver-port

Conversation

@ds5678
Copy link
Copy Markdown
Collaborator

@ds5678 ds5678 commented May 13, 2024

No description provided.

@ds5678 ds5678 marked this pull request as draft May 13, 2024 06:12
@ds5678 ds5678 force-pushed the asmresolver-port branch from af34228 to be14f9d Compare June 29, 2024 19:03
@ds5678 ds5678 marked this pull request as ready for review July 1, 2024 05:46
@ds5678 ds5678 force-pushed the asmresolver-port branch from 9a5de7e to 5e58d9e Compare July 7, 2024 17:41
@ds5678
Copy link
Copy Markdown
Collaborator Author

ds5678 commented Jul 13, 2024

After doing some more validation, I discovered that the Cecil HasOverrides property was always returning false. In light of that, I have removed the HasOverrides check entirely. The output is now almost exactly consistent.

@ds5678
Copy link
Copy Markdown
Collaborator Author

ds5678 commented Jul 13, 2024

The validator is available here: https://github.com/AssetRipper/AssetRipper.CIL/tree/ecdd481b87f5f4872897d7408eae6eedaab5834e/AssetRipper.CIL.Validator

@ds5678
Copy link
Copy Markdown
Collaborator Author

ds5678 commented Jul 15, 2024

@SamboyCoding Thank you for the review! I'll address these tonight.

@ds5678
Copy link
Copy Markdown
Collaborator Author

ds5678 commented Jul 16, 2024

Thanks again for the review. I made some changes based on your feedback.

* Declare System.Runtime as our corlib
* Add TargetFrameworkAttribute to generated assemblies
@ds5678
Copy link
Copy Markdown
Collaborator Author

ds5678 commented Jul 17, 2024

Note: my latest commit "broke" consistency due to changing the corlib, which caused a ton of imported references to become inequal, but otherwise it's still consistent.

ds5678 added a commit to ds5678/Il2CppInterop that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generation Related to assembly generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants