Do not throw ArgumenNullException in ConfigSettingEntry.GetAcceptedValues #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `supportedTypes` Type array (containing the types of `AcceptableValueList` & `AcceptableValueRange`). - Added method `isTypeSupported` to check if a type is a subclass or an instance of a type in `supportedTypes` via `IsSubclassOfRawGeneric`. - Added `IsSubclassOfRawGeneric(Type generic, Type toCheck)` method which checks if `toCheck` is a subclass or an instance of `generic`.
…ue` fields for a custom range class See issue's comments for a in-depth explanation
ManlyMarco
approved these changes
Apr 5, 2024
starfi5h
pushed a commit
to starfi5h/BepInEx.ConfigurationManager
that referenced
this pull request
Oct 31, 2025
…lues (BepInEx#89) This PR removes the ArgumenNullException present in ConfigSettingEntry.GetAcceptedValues(AcceptableValueBase values), enforcing the use of both MinValue and MaxValue for custom range classes (see issue's comments for a in-depth explanation) Fixes BepInEx#88 (cherry picked from commit 19cff15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ArgumenNullExceptionpresent inConfigSettingEntry.GetAcceptedValues(AcceptableValueBase values), enforcing the use of bothMinValueandMaxValuefor custom range classes (see issue's comments for a in-depth explanation)