ci(pr): build macOS + Windows on src/deps changes (path-aware)#492
Merged
Conversation
The PR build only ran Debian/Fedora, so platform-specific compile/link failures (AppleClang constexpr, macOS-SDK issues, Win-ARM64 LNK2001, the Assimp bundled-zlib break) only surfaced after merge in the nightly/RC. Add a 'code' output to the detect job (true on src/deps/CMakeLists/version.inc changes — deps always count, never skipped) and run macOS (15 ARM Universal) + Windows (2022 x64) when it is set. Doc-only and most workflow-only PRs still don't trigger a build at all (paths filter); pure packaging changes still only run the relevant Linux job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the PR build path-aware so platform-specific breakage is caught in the PR, not after merge in the nightly/RC.
detectjob gains acodeoutput (src/deps/CMakeLists/version.inc; deps never skipped)code == trueWill be merged together with the running develop nightly batch.
Closes #491