refactor: simplify rerun.feature by moving setup to Background #1770
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Dec 9, 2025
acoulton
approved these changes
Dec 9, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Great, thanks for doing this @carlos-granados
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@acoulton seeing your comments in #1764 and #1766 I agree with what you exposed there and I have decided to start by updating the original
reruntest to remove the scenario that is unnecessary and to make it more explicit the results of the initial run. Once this is merged, I will update the other PRs