refactor: convert rerun_strict tests to use fixtures #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoulton
reviewed
Dec 9, 2025
Comment on lines
14
to
28
| When I run "behat features/rerun_strict.feature" | ||
| And I run "behat --rerun features/rerun_strict.feature" |
Contributor
There was a problem hiding this comment.
See the comments on #1764 - in this feature we don't have a separate scenario that proves the fixture is broken at first (which is correct IMO).
However our initial When I run "behat features/rerun_strict.feature" in both scenarios should assert the expected result & output so that we can see how it differs on the second --rerun execution.
dd9cf0d to
6095bcd
Compare
acoulton
approved these changes
Dec 9, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Perfect, thanks @carlos-granados
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case we could not re-use the fixtures as they were very different from the existing ones