Check JSON file before running all tests #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@acoulton this is the issue that I found and that I wanted to fix before we did the release |
acoulton
approved these changes
Oct 28, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
LGTM, thanks @carlos-granados
acoulton
added a commit
to acoulton/Behat
that referenced
this pull request
Oct 28, 2025
acoulton
added a commit
to acoulton/Behat
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation, the checks for the JSON file (check that the output path had been passed, that it was not a directory, that we could create the file) would not happen until after all the tests had been run, which could be very inconvenient, run all tests only to find that you cannot write the file.
In this PR we change this to follow what the JUnit formatter does, which is to try to create the file at the beginning of the test run.