Shortened LobbyManager code and probably over-commented it#12
Closed
cubicgraphics wants to merge 2 commits intoBeatTogether:devfrom
Closed
Shortened LobbyManager code and probably over-commented it#12cubicgraphics wants to merge 2 commits intoBeatTogether:devfrom
cubicgraphics wants to merge 2 commits intoBeatTogether:devfrom
Conversation
Member
Member
|
@cubicgraphics Thank you for this PR! It definitely helps to have more contributors! Are you in our Discord? We would love to have you! I've also tagged our main maintainer to check this over and make sure it's all set. |
Member
Author
yea, cubic²#6837 |
Member
Author
|
I am going to make a new pull request soon, going to close this one as the new one will just be this one, some fixed comments and other stuff |
cubicgraphics
added a commit
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should still work, may need checking though, left a comment near to something i think is related to where found that bug i reported on discord with lobbies breaking if a song is not finished.