Skip to content

Suggestions from George#15

Closed
astridx wants to merge 1 commit intoBakual:40_AddDashboardMenufrom
astridx:40_AddDashboardMenu
Closed

Suggestions from George#15
astridx wants to merge 1 commit intoBakual:40_AddDashboardMenufrom
astridx:40_AddDashboardMenu

Conversation

@astridx
Copy link
Copy Markdown

@astridx astridx commented Mar 1, 2020

@Bakual
Copy link
Copy Markdown
Owner

Bakual commented Mar 1, 2020

@astridx Dankeschön. Aber die Suggestions kann man direkt im originalen PR mittels Knopfdruck annehmen. Da ist GitHub echt nett 😃

@Bakual Bakual closed this Mar 1, 2020
@astridx astridx deleted the 40_AddDashboardMenu branch August 9, 2020 12:29
Bakual pushed a commit that referenced this pull request Jan 6, 2022
* Add some events when fetching media data

* Use dispatcher to trigger event

* Use an event instance

* Class per event (#15)

* Argument validations and getter (#16)

* Class per event

* Argument validations

* global

* Use result from events

* Copy year

* Use internal variable

* void

* adapt model

* Validate events (#17)

* Revert commit ec8b4c8 ccd02cb and 9a2a119

* Validate and immutable events

* Update administrator/components/com_media/src/Event/FetchMediaFileEvent.php

Co-authored-by: Harald Leithner <leithner@itronic.at>

* Update administrator/components/com_media/src/Event/FetchMediaFilesEvent.php

Co-authored-by: Harald Leithner <leithner@itronic.at>

* Rename the events

* Cleanup events

Co-authored-by: Fedir Zinchuk <getthesite@gmail.com>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants