Consolidate tools. #789
Consolidate tools. #789
Conversation
…ng device_query, finetune_net, net_speed_benchmark, train_net
|
Evan, Jeff, Jon - this is the idea we discussed about over emails. Please see if such direction seems right to you. |
|
Nice, this will be great! I have a couple subjective suggestions:
|
|
The ".bin" extension is added by the makefile, so that would be easy to change. I am a little inclined to not have unnamed parameters - since then one has to remember for each command what is needed, and in the code we will have to do argv[2] type stuff again. having a name prepending each parameter will be a little longer but will make every parameter (other than the action verb) more semantically reasonable. Also, if we want to change parameters in the future, hard-coded argv will be hard to maintain. |
|
K, your reasoning on not using unnamed parameters makes sense. On the .bin extension, maybe we should leave it in the Makefile since otherwise people will try to run |
|
Makes sense. I am leaving the .bin as is since if we want, we can simply add ln -s build/tools/caffe.bin build/tools/caffe and have it solved. Also, we will need to change our various documentations and start using "caffe action" type command. @shelhamer @longjon any opinions? I'll merge for now if it looks OK. |
|
The example scripts ( |
tools/train_net.cpp
Outdated
There was a problem hiding this comment.
maybe these should be LOG(FATAL)s?
There was a problem hiding this comment.
(obviously this doesn't matter much because the tool no longer does anything anyway, but I think it might be good to have the script fail by returning 1 and/or LOG(FATAL)ing in case someone actually makes use of those exit codes to see if their script calling train_net.bin succeeded)
There was a problem hiding this comment.
Thanks for consolidating like we talked about @Yangqing! Looks good to
merge once the bundled examples are updated and Jeff's comments are
addressed.
I too would rather have "caffe" instead of "caffe.bin" but for deprecation
let's just add the symlink to the Makefile, then in the following
release drop the .bin.
On Friday, July 25, 2014, Jeff Donahue notifications@github.com wrote:
In tools/train_net.cpp:
- SolverParameter solver_param;
- ReadProtoFromTextFileOrDie(argv[1], &solver_param);
- LOG(INFO) << "Starting Optimization";
- SGDSolver solver(solver_param);
- if (argc == 3) {
- LOG(INFO) << "Resuming from " << argv[2];
- solver.Solve(argv[2]);
- } else {
- solver.Solve();
- }
- LOG(INFO) << "Optimization Done.";
- LOG(ERROR) << "Deprecated. Use caffe.bin train --solver_proto_file=... "
"[--resume_point_file=...] instead.";(obviously this doesn't matter much because the tool no longer does
anything anyway, but I think it might be good to have the script fail by
returning 1 and/or LOG(FATAL)ing in case someone actually makes use of
those exit codes to see if their script calling train_net.bin succeeded)—
Reply to this email directly or view it on GitHub
https://github.com/BVLC/caffe/pull/789/files#r15431553.
There was a problem hiding this comment.
Sounds good, I'll change the examples. Not doing the symlinking for now - maybe let's explicitly switch when all the tools are in one binary.
|
Done updating and passing travis, merging :) |
|
@Yangqing or other gflag / glog experts: what's the simplest way to make the consolidated tools produce (normal, successful) output by default? For instance, I'd like to prepare a release but before that the consolidated tool should be friendly and the examples should use it. |
|
Sorry, I missed it in the glog documentation before. It's just |
Consolidate tools.
Consolidate tools.
This is to consolidate the various tools that caffe has into one single binary ("caffe.bin"), and deprecate the multiple binaries hard to remember. In the meantime, we will also switch to the gflags library and get rid of all the argv[4] type hard-coding.
As a result, if you want to do device query, do:
build/tools/caffe.bin devicequery --device_id=0
if you want to do e.g. training with an option of finetuning, do
build/tools/caffe.bin train --solver_proto_file=solver.prototxt [--pretrained_net_file=pretrained.binaryproto]
I have currently deprecated device_query, train_net, finetune_net, net_speed_benchmark. Others could be potentially deprecated in the same way.