Gflags dependency & misc #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Adding gflags travis script... hope this time it passes. |
Member
Author
|
Oh well, linker complains about gflags not compiled with -fPIC: /usr/bin/ld: /usr/local/lib/libgflags.a(gflags.cc.o): relocation R_X86_64_32S against `std::basic_string<char, std::char_traits, std::allocator >::_Rep::_S_empty_rep_storage' can not be used when making a shared object; recompile with -fPIC Will check later when I get off work today. |
added 4 commits
July 24, 2014 10:28
…gflags installation.
… first and then gflags.
Member
Author
|
Passed! @shelhamer @jeffdonahue if you don't object, I'll merge :) |
Contributor
|
LGTM |
4 tasks
Member
There was a problem hiding this comment.
This should be glog first, right? I edited in fdb1903.
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Gflags dependency & misc
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Gflags dependency & misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding gflags dependency. tools consolidation to follow separately.
Also, changed the behavior of device query: they now output to LOG(INFO) to be consistent with other logs.
It might be the case that travis does not pass - I'll check the travis script and make it right (not a travis expert).