Fix bug introduced by warning logs (errors didn't print) #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are logged to the warnings file
jeffdonahue
added a commit
that referenced
this pull request
Jul 9, 2014
Fix bug introduced by warning logs (errors didn't print)
Member
|
Oh, sorry. I missed that too. |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Fix bug introduced by warning logs (errors didn't print)
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Fix bug introduced by warning logs (errors didn't print)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I missed that this would be an issue but after my warning logging by redirecting the compiler's stderr output to a file, errors no longer printed as they were just getting sent to that file (of course) and then make will immediately stop when any command returns a non-zero exit code so the
cat <warning file>command wasn't being reached. I don't know of a way to avoid the errors going to the warning logs (seems ok to me), so now if compilation fails I print that warning log file and exit with a non-zero code.