Skip to content

fix a bug that time duration may be 0 when downloading model binary #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shelhamer merged 1 commit into from
Dec 2, 2015
Merged

fix a bug that time duration may be 0 when downloading model binary #3313

shelhamer merged 1 commit into from
Dec 2, 2015

Conversation

@gdh1995
Copy link
Contributor

@gdh1995 gdh1995 commented Nov 10, 2015

Sometimes urllib calls a hook the first time and then the second in a time distance too shorter than 1 second, in which case download_model_binary.py will break. This commit fixes this crash.

Extra information:

  • When I ran scripts/download_model_binary.py to download caffe model, it once reported;
Traceback (most recent call last):
  File "***/caffe\scripts/download_model_binary.py", line 73, in <module>
    frontmatter['caffemodel_url'], model_filename, reporthook)
  File "d:\Python27\lib\urllib.py", line 93, in urlretrieve
    return _urlopener.retrieve(url, filename, reporthook, data)
  File "d:\Python27\lib\urllib.py", line 274, in retrieve
    reporthook(blocknum, bs, size)
ZeroDivisionError: float division by zero
  • I saw the output file and found the count was about 6 KB.
  • Windows 8.1 Pro x64, Python 2.7 (32 bits) with urllib-1.17

shelhamer added a commit that referenced this pull request Dec 2, 2015
@shelhamer
Merge pull request #3313 from gdh1995/master
fe3abd0 
don't divide by 0 duration when downloading model binary
@shelhamer shelhamer merged commit fe3abd0 into BVLC:master Dec 2, 2015
@shelhamer
Copy link
Member

shelhamer commented Dec 2, 2015

Thanks -- this doesn't seem like a common issue but it doesn't hurt to avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gdh1995 @shelhamer