-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Display and store cuDNN version numbers during cmake. #3267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cbalint13
commented
Nov 1, 2015
- This simple patch allows version display and storage for cuDNN external plugin detection process. It is based on cudnn.h parsing, and can parse booth v2 and newer of future releases. See prints below:
|
It's good to confirm the detected cuDNN. @lukeyeager could you check this? |
|
I pulled the branch and checked it against various cuDNN versions. Seems to work correctly for >= v2, and fail gracefully for older versions: I've verified with the cuDNN team that they plan to stick to this style of declaring the version in the header, so this should keep working with future versions. One suggestion - I would like to see the version number printed in the summary as well: Something like |
|
@lukeyeager , will work on update in this case.
|
Waiting for "v2-rc3" header file confirmal, if can help me with the header file. |
|
@cbalint13 Caffe doesn't support cuDNN < v3 since #3160. So I wouldn't worry about parsing older versions. I just provided extra info because I had it handy. Failing to parse v1 headers is perfectly fine. Displaying |
|
First thanks a lot for your feedback ! Lets then settle down:
For (a) or (b) cmake will halt with: Do you agree ? If yes, will proceed coding it up. |
And for versions below v3 i considered to simply halt and display ???: |
That sounds reasonable to me, and a nice improvement. I tried it and it works as you described - errors when version < 3. |
[build] Display and store cuDNN version numbers for CMake
|
Thanks for the build improvement @cbalint13 and guidance @lukeyeager. |