-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Exposing layer top and bottom names to python #2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
22b07de to
1e7cc54
Compare
b32022a to
7d4890a
Compare
7d4890a to
6d8c035
Compare
|
Seems like a reasonable thing to expose to pycaffe. A couple questions:
|
|
thanks for the feedback. As for the C++ exposition, I didn't see a way of exposing it to python without exposing something to C++, but I'm open to suggestions. |
bbe3bd1 to
a723331
Compare
a723331 to
f80f1c3
Compare
bbf2565 to
f578605
Compare
f578605 to
60b353b
Compare
60b353b to
a7a3222
Compare
a7a3222 to
6632aa5
Compare
b811915 to
a711733
Compare
a711733 to
4e65cdf
Compare
include/caffe/net.hpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to CHECK_GE(i, 0), yes?
|
The new patch looks pretty reasonable; comments as noted. Also:
|
f88b9c5 to
1137e89
Compare
|
Not sure where to compute the |
|
Right, due to the awkwardness of the current method rewriting scheme, it would need to be done in a similar way to the other |
Exposing layer top and bottom names to python
|
Okay, I'll go ahead and merge as is; while it would be nice to have Thanks for this exposure @philkr! |
This PR allows the python interface to access the top and bottom blob names, which makes the data flow a bit more explicit in python.