Fix minor issues related to CUDA_KERNEL_LOOP #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdonahue
added a commit
that referenced
this pull request
Mar 19, 2014
Fix minor issues related to CUDA_KERNEL_LOOP -- merging myself as I'm only adding/removing comments other than the addition of CUDA_KERNEL_LOOP to PaddingLayer (and checked that this passes all tests).
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
…ents Fix minor issues related to CUDA_KERNEL_LOOP -- merging myself as I'm only adding/removing comments other than the addition of CUDA_KERNEL_LOOP to PaddingLayer (and checked that this passes all tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "if (index < n)"-type comments that no longer apply due to CUDA_KERNEL_LOOP (as noted by @jamt9000 in #239) and use CUDA_KERNEL_LOOP in padding layer.
Also fix a few remaining lint errors from images_layer -- as of this PR, dev is lint clean.