Add libcaffe.a to dependencies for TEST_ALL_BIN #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is pretty safe (just adds two (clearly necessary) dependencies to runtest) -- merging myself now so I can stop cherrypicking the Makefile from this PR to run tests. |
jeffdonahue
added a commit
that referenced
this pull request
Mar 19, 2014
Add libcaffe.a to dependencies for TEST_ALL_BIN
Member
|
Hey Jeff, agreed this was a totally safe merge. Next time you might as well just push to dev directly and save yourself the trouble. |
Contributor
Author
|
Eh, I don't mind making PRs, I kind of like having them as records (but it's fine by me if you and the other collaborators want to push very safe and small changes directly to dev). |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Add libcaffe.a to dependencies for TEST_ALL_BIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, running
make clean && make testgave the errorg++: error: libcaffe.a: No such file or directory. This fixes that.Edit:
make clean && make runtestwas giving a similar errorg++: error: build/src/gtest/gtest-all.o: No such file or directory; commit 9251ae7 fixes that as well.