cmake and python3 bugfixes for #1939 and #1923 #1966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me. @Nerei, this reverts a change made by you; do you agree? |
|
👍 Ok change. Never knew that someone included caffe in this way. |
|
I have tried to use Caffe with Python 3 and I am still finding some bugs related to Python 3 |
Contributor
|
Okay, merging. @andresromero, I believe you need protobuf 3.0.0-alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1939 replaced PROJECT_SOURCE_DIR with CMAKE_SOURCE_DIR, which breaks building caffe as a subproject (see #1899). This PR reverts to PROJECT_SOURCE_DIR.
Python3 requires
listaroundself.blobs.keys().