Cross-channel LRN bounds checking for GPU implementation #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdonahue
added a commit
that referenced
this pull request
Mar 18, 2015
Cross-channel LRN bounds checking for GPU implementation
Contributor
|
Thanks for the fix and new unit tests @erictzeng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864.
When the
local_sizeof aLRNLayerinACROSS_CHANNELSmode is larger than the number of channels in a blob, we get some nasty indexing errors in the GPU implementation (the CPU implementation is fine). This pull request consists of two contributions:TestForwardAcrossChannelsLargeRegionandTestGradientAcrossChannelsLargeRegionthat use alocal_sizeof 15 on a blob with 7 channels. These tests break the current master implementation.As far as I can tell, this PR is complete, though if anyone finds anything wrong with it of course I'd be happy to fix.