Skip to content

Conversation

@kloudkl
Copy link
Contributor

@kloudkl kloudkl commented Feb 20, 2014

@kloudkl
Copy link
Contributor Author

kloudkl commented Feb 20, 2014

@mavenlin, I observed no significant difference among pure CPU timer, CPU timer with cudaDeviceSynchronize, and cudaEvent_t based GPU timer. Are these what you called weird results?

@kloudkl kloudkl closed this Feb 20, 2014
@kloudkl
Copy link
Contributor Author

kloudkl commented Feb 25, 2014

Reopen to simplify future benchmark works.

@kloudkl kloudkl reopened this Feb 25, 2014
@shelhamer
Copy link
Member

Please rebase on the latest dev and we'll merge. Thanks.

@kloudkl
Copy link
Contributor Author

kloudkl commented Feb 26, 2014

@shelhamer, it has been rebased and polished with the newly added cpplint.

@shelhamer
Copy link
Member

So sorry, but this needs another rebase because of a complicated merge. If it's any consolation, this has prepared the reconciliation of the MKL and non-MKL versions of Caffe and brought in support for DAGs, improved documentation, and a better organization of the project.

We are adopting a new development strategy that will not have a constant need for rebasing. It will be documented shortly, but the bottom line is that we will no longer rewrite the history of dev.

@kloudkl
Copy link
Contributor Author

kloudkl commented Mar 4, 2014

I am glad that Caffe is approaching version 1.0. The workflow that I used to rebase on the most recent merge is as follows.

git remote update upstream
git checkout -b Timer upstream/dev
git cherry-pick ...[first commit of this issue]
git cherry-pick ...[second commit of this issue]
...
git push -f origin Timer:cuda_timing

Absolutely clean history.

@sguada sguada self-assigned this Mar 4, 2014
@kloudkl
Copy link
Contributor Author

kloudkl commented Mar 11, 2014

@shelhamer, this utility class is rebased and tested again. Please merge it for those who are interested in benchmarking run time. Thanks!

shelhamer added a commit that referenced this pull request Mar 13, 2014
Add Timer class unifying CPU and GPU timer and use it in net_speed_benchmark
@shelhamer shelhamer merged commit 04d6595 into BVLC:dev Mar 13, 2014
@shelhamer
Copy link
Member

@kloudkl Thanks! We're catching up on PRs now, so hope to merge lots of the new developments soon.

@kloudkl kloudkl deleted the cuda_timing branch March 15, 2014 11:06
@shelhamer shelhamer mentioned this pull request Mar 18, 2014
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
Add Timer class unifying CPU and GPU timer and use it in net_speed_benchmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants