[fix] translate g++ whole archive to force load for clang++ compilation #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build with the layer registry clang++ requires `-force_load` as g++ requires `--whole-archive`.
Merged
Member
Author
|
@akosiorek @bhack or other CMake devs it might be worth checking the CMake build, pycaffe, and matcaffe with this change and the new layer factory from #1167. |
|
Works for me. Your patch makes more sense than what I was using on my side: putting -force_load under OSX. |
shelhamer
added a commit
that referenced
this pull request
Oct 3, 2014
[fix] translate g++ whole archive to force load for clang++ compilation
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Oct 11, 2014
[fix] translate g++ whole archive to force load for clang++ compilation
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
[fix] translate g++ whole archive to force load for clang++ compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build with the layer registry clang++ requires
-force_loadasg++ requires
--whole-archive.This fixes the OS X build.