Skip to content

fix name and add graph beta support#2273

Merged
jmprieur merged 2 commits into
jmprieur/Graph5from
jennyf/Graph5
Jun 12, 2023
Merged

fix name and add graph beta support#2273
jmprieur merged 2 commits into
jmprieur/Graph5from
jennyf/Graph5

Conversation

@jennyf19

Copy link
Copy Markdown
Collaborator

No description provided.

@jennyf19 jennyf19 requested a review from jmprieur June 10, 2023 23:00

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
using Microsoft.Graph;
using Microsoft.Graph.Drives.Item.Items.Item.Workbook.Functions.Beta_Dist;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Graph" Version="5.12.0" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need Graph too? or only GraphBeta?

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

@jmprieur jmprieur merged commit 9923dec into jmprieur/Graph5 Jun 12, 2023
jmprieur added a commit that referenced this pull request Jun 13, 2023
* Spec-in dev ex with Graph 5
* add graph beta support (#2273)
* fix sample (#2278)
* Fixing the tests
* Adding GraphServiceClient modifiers (WithAppOnly, WithSCopes, ....) (#2279)
* Updating the README.md
---------
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
@jmprieur jmprieur deleted the jennyf/Graph5 branch October 12, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants