Cache file console app #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Jun 4, 2020
rayluo
reviewed
Jun 4, 2020
| from msal_extensions import FilePersistence, CrossPlatLock | ||
|
|
||
|
|
||
| def _acquire_lock_and_write_to_cache(cache_location, sleep_interval): |
Contributor
There was a problem hiding this comment.
I believe @bgavrilMS wants:
accepts 3 inputs: string protectedFilePath, string lockFilePath and int millisecondsToSleep
Contributor
Author
There was a problem hiding this comment.
I can change to take this parameter as an input but I was just wondering if its actually needed as it follows the same pattern across libraries
Contributor
There was a problem hiding this comment.
Fair enough, unless @bgavrilMS has any objection. :-)
Now, how about we just have this new cache_file_console_app branch merge back to your perf_testing branch, and then we conclude this whole thing there?
rayluo
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding console app for cross-platform testing in #60