Skip to content

Add debugging link on resource deployment failures to log output#1202

Merged
2 commits merged intoAzure:masterfrom
benbp:benbp/live-test-docs
Nov 13, 2020
Merged

Add debugging link on resource deployment failures to log output#1202
2 commits merged intoAzure:masterfrom
benbp:benbp/live-test-docs

Conversation

@benbp
Copy link
Copy Markdown
Member

@benbp benbp commented Nov 12, 2020 •
edited
Loading

Available information currently gets logged on failures with ARM template provisioning, but we should provide a link to help people who want to debug further or understand what is going wrong.

@benbp benbp mentioned this pull request Nov 12, 2020
Merged
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Nov 12, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Nov 12, 2020
View reviewed changes
Comment thread eng/common/TestResources/New-TestResources.ps1 Outdated
weshaggard
weshaggard reviewed Nov 12, 2020
View reviewed changes
Comment thread eng/common/TestResources/New-TestResources.ps1 Outdated
weshaggard
weshaggard reviewed Nov 12, 2020
View reviewed changes
Comment thread eng/common/TestResources/New-TestResources.ps1 Outdated
@benbp benbp requested a review from weshaggard November 12, 2020 18:47
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Nov 12, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Nov 12, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 13, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link
Copy Markdown

ghost commented Nov 13, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 546a4e9 into Azure:master Nov 13, 2020
@benbp benbp deleted the benbp/live-test-docs branch November 13, 2020 01:33
weshaggard
weshaggard reviewed Nov 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benbp added a commit that referenced this pull request Dec 1, 2020
@benbp
Add debugging link on resource deployment failures to log output (#1202)
77d9784 
Available information currently gets logged on failures with ARM template provisioning, but we should provide a link to help people who want to debug further or understand what is going wrong.
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@danewalton-msft
update sample readme (Azure#1202)
c6d06a4
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

@heaths heaths heaths approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benbp @azure-sdk @heaths @weshaggard