Add Log Handler Filter To workload tests to reduce logging noise#40700
Merged
bambriz merged 3 commits intoAzure:mainfrom Apr 24, 2025
Merged
Add Log Handler Filter To workload tests to reduce logging noise#40700bambriz merged 3 commits intoAzure:mainfrom
bambriz merged 3 commits intoAzure:mainfrom
Conversation
Added filters for the worklaod test logger handler. It will only log when database account read happens, when latency is above 1000ms, and if there is an error. It won't log certain errors such as 404/0, 409/0, and 412/0. Given the test uses randint for upserting and reading documents a 404/0 and 409/0 is bound to occur and would just be considered noise for the workload tests.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a filter to reduce logging noise during workload tests by filtering out non-critical log events.
- Added definitions for _NOISY_ERRORS and _NOISY_SUB_STATUS_CODES.
- Introduced the WorkloadLoggerFilter class with logic for filtering unnecessary log records.
- Integrated the new filter into the logger configuration in create_logger.
Collaborator
|
API change check API changes are not detected in this pull request. |
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
) * Update workload_utils.py Added filters for the worklaod test logger handler. It will only log when database account read happens, when latency is above 1000ms, and if there is an error. It won't log certain errors such as 404/0, 409/0, and 412/0. Given the test uses randint for upserting and reading documents a 404/0 and 409/0 is bound to occur and would just be considered noise for the workload tests. * Update workload_utils.py * Update workload_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added filters for the workload test logger handler. It will only log when database account read happens, when latency is above 1000ms, and if there is an error. It won't log certain errors such as 404/0, 409/0, and 412/0. Given the test uses randint for upserting and reading documents a 404/0 and 409/0 is bound to occur and would just be considered noise for the workload tests.
The following filter is being used: