[EventHubs] Get IoT Hub Name from Redirect Address in sample#19314
Merged
3 commits merged intoAzure:mainfrom Jun 23, 2021
Merged
[EventHubs] Get IoT Hub Name from Redirect Address in sample#193143 commits merged intoAzure:mainfrom
3 commits merged intoAzure:mainfrom
Conversation
jsquire
approved these changes
Jun 18, 2021
Member
jsquire
left a comment
There was a problem hiding this comment.
The approach looks correct to me.
yunhaoling
reviewed
Jun 18, 2021
Contributor
yunhaoling
left a comment
There was a problem hiding this comment.
this looks amazing :)
could you add a short comment to help understand the expression?
also I believe it is tested? (e.g. names longer than 25 chars)
yunhaoling
approved these changes
Jun 22, 2021
|
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 24, 2021
…into get_testserver_working * 'main' of https://github.com/Azure/azure-sdk-for-python: (45 commits) ignore coretestserver readme (Azure#19436) Add Ubuntu 20 to local dns bypass template (Azure#19432) Sync eng/common directory with azure-sdk-tools for PR 1729 (Azure#19415) Async/BearerTokenCredentialPolicy consistently calls on_exception (Azure#19195) [EventHubs] Fix bug in sending stress test code and update default stress test settings (Azure#19429) [EventHubs] Get IoT Hub Name from Redirect Address in sample (Azure#19314) [textanalytics] regen on v3.1 (Azure#19193) Adapt EG to arm template (Azure#19262) [Key Vault] Extend pipeline test timeout (Azure#19404) Update platform matrix to ubuntu 20 (Azure#19296) [AppConfig] Add lock to SyncTokenPolicy (Azure#19395) Regenerate monitor code (Azure#19375) Increment version for keyvault releases (Azure#19402) Aggregation should be a list (Azure#19381) [azure-mgmt-monitor] skip test to unblock ci (Azure#19390) Cloud event should parse smaller ms precisions (Azure#19259) Update release date (Azure#19399) [Communication]: use x-ms-date for hmac (Azure#19396) [Key Vault] Performance tests for certificates, keys, and secrets (Azure#19002) Deprecate azure-monitor (Azure#19384) ...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #19087
Follows C# sample, which also gets IoT Hub name from redirect address.