Merged
Conversation
| match_condition=MatchConditions.Unconditionally, | ||
| **kwargs | ||
| ): # type: (str, Optional[str], Optional[str], Optional[MatchConditions], **Any) -> ConfigurationSetting | ||
| ): # type: (str, Optional[str], Optional[str], Optional[MatchConditions], **Any) -> Optional[ConfigurationSetting] |
Contributor
There was a problem hiding this comment.
This seems odd to me. Is there a way that you can call this method and it will return None instead of a ConfigurationSetting? This could almost be considered a breaking change if we used to document this as always returning a ConfigurationSetting.
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
kristapratico
approved these changes
Jun 17, 2021
| etag="*", # type: Optional[str] | ||
| match_condition=MatchConditions.Unconditionally, # type: Optional[MatchConditions] | ||
| **kwargs # type: Any | ||
| ): # type: (...) -> Union[None, ConfigurationSetting] |
Contributor
There was a problem hiding this comment.
This still seems odd to me, but if it's the expected behavior then I think we should probably update the :rtype: in the docstring and perhaps explain in :return: what case None could be returned
Contributor
There was a problem hiding this comment.
Ah I didn't see the auto-merge tag, sorry
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2021
…into get_testserver_working * 'master' of https://github.com/Azure/azure-sdk-for-python: (55 commits) [AppConfig] mypy fixes (Azure#18858) [translation] renames (Azure#19285) [Key Vault] Update metadata for release (Azure#19286) [AppConfig] enable samples (Azure#18857) KeyVaultBackupOperation -> KeyVaultBackupResult (Azure#19284) renaming (Azure#19280) [Key Vault] Custom polling method for admin backup client (Azure#19204) [textanalytics] add ARM template + run samples in CI (Azure#19270) removed example from description (Azure#18781) [Key Vault] Update READMEs with RBAC information (Azure#19275) Sync eng/common directory with azure-sdk-tools for PR 1688 (Azure#19272) update all ubuntu vmImage to 20.04 (Azure#19227) add base class for feedback (Azure#19265) Enable tests for integration samples (Azure#18531) docs: fix a few simple typos (Azure#19127) Increment package version after release of azure-eventgrid (Azure#19197) Increment package version after release of azure-monitor-query (Azure#19208) earliest versions of communication identity tests are set up improperly. skip 1.0.0 in regression testing (Azure#19258) Run mypy in azure-keyvault-administration CI (Azure#19246) [text analytics] change return type of analyze actions to list of list (Azure#18994) ...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18540