Skip to content

Adding configurable process timeout for DeveloperCredentials#28792

Merged
christothes merged 12 commits intoAzure:mainfrom
reynaldoburgos:AzurePowershellCredentials_timeout
Sep 9, 2022
Merged

Adding configurable process timeout for DeveloperCredentials#28792
christothes merged 12 commits intoAzure:mainfrom
reynaldoburgos:AzurePowershellCredentials_timeout

Conversation

@reynaldoburgos
Copy link
Copy Markdown
Contributor

@reynaldoburgos reynaldoburgos commented May 15, 2022 •
edited
Loading

Adding configurable process timeout for DeveloperCredentials:

  1. Azure CLI
  2. Azure Powershell
  3. VisualStudio Credential

Proposed solution for [FEATURE REQ]
#23135
#28734

@ghost ghost added Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 15, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 15, 2022

Thank you for your contribution @reynaldoburgos! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label May 15, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 15, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@reynaldoburgos
Copy link
Copy Markdown
Contributor Author

reynaldoburgos commented May 31, 2022

looking for PR review

christothes
christothes reviewed Jun 3, 2022
View reviewed changes
Comment thread sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredentialOptions.cs Outdated
@reynaldoburgos reynaldoburgos changed the title Adding configurable process timeout to AzurePowershellCredentials Adding configurable process timeout for DeveloperCredentials Sep 1, 2022
@reynaldoburgos reynaldoburgos requested review from christothes and removed request for KrzysztofCwalina, ShivangiReja, schaabs and tg-msft September 1, 2022 23:10
snakefoot
snakefoot reviewed Sep 8, 2022
View reviewed changes
Comment thread sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs Outdated
christothes
christothes reviewed Sep 8, 2022
View reviewed changes
Comment thread sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredential.cs
Comment thread sdk/identity/Azure.Identity/tests/AzureCliCredentialTests.cs Outdated
christothes
christothes approved these changes Sep 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christothes christothes merged commit 16934e9 into Azure:main Sep 9, 2022
@dougdenn dougdenn mentioned this pull request Sep 22, 2022
Closed
This was referenced Nov 15, 2022
Closed
Closed
Closed
Closed
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@reynaldoburgos @sofiar-msft
Adding configurable process timeout for DeveloperCredentials (Azure#2…
3b26537 
…8792)

* Adding configurable process timeout to developer credentials
@pvaneck pvaneck mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christothes christothes christothes approved these changes

+1 more reviewer

@snakefoot snakefoot snakefoot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reynaldoburgos @christothes @snakefoot