Connection string SASs now sanitized#20520
Merged
jaschrep-msft merged 3 commits intoAzure:masterfrom Apr 12, 2021
Merged
Conversation
Same code is now applied to a SAS found in a connection string as is applied to a SAS found with builder.endpoint().
Test previously did a string comparison ignoring case. Code no longer guarantees same ordering of sas query parameters, so the SAS must now have its deconstructed contents compared.
alzimmermsft
approved these changes
Apr 12, 2021
kasobol-msft
approved these changes
Apr 12, 2021
benbp
pushed a commit
that referenced
this pull request
Apr 28, 2021
* Connection string SASs now sanitized Same code is now applied to a SAS found in a connection string as is applied to a SAS found with builder.endpoint(). * Fixed connection string SAS test. Test previously did a string comparison ignoring case. Code no longer guarantees same ordering of sas query parameters, so the SAS must now have its deconstructed contents compared. * CI fixes Fixed test recording issues. Fixed checkstyle issue. Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same code is now applied to a SAS found in a connection string as is
applied to a SAS found with builder.endpoint().