Skip to content

[Do Not Merge] Add API for adding external storage account configurations to a web app#3444

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
ebencarek:master
Jul 19, 2018
Merged

[Do Not Merge] Add API for adding external storage account configurations to a web app#3444
jhendrixMSFT merged 1 commit intoAzure:masterfrom
ebencarek:master

Conversation

@ebencarek
Copy link
Copy Markdown
Contributor

@ebencarek ebencarek commented Jul 19, 2018 •
edited by azuresdkci
Loading

Redo of #3423 which was already approved, I messed up the commit history when rebasing.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from jhendrixMSFT July 19, 2018 00:01
@ebencarek
Copy link
Copy Markdown
Contributor Author

ebencarek commented Jul 19, 2018

Redo of #3423 which was already approved, I messed up the commit history when rebasing.

@AutorestCI AutorestCI mentioned this pull request Jul 19, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2065

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2266

This was referenced Jul 19, 2018
Merged
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp6d0_0c0z/rest/specification/web/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp6d0_0c0z/sdk', '--nodejs']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4280; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

@AutorestCI AutorestCI mentioned this pull request Jul 19, 2018
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpsm9c0zlo/rest/specification/web/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpsm9c0zlo/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.71', '--verbose']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4280; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.71->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-02"} .

@ebencarek ebencarek mentioned this pull request Jul 19, 2018
Closed
10 tasks
@jhendrixMSFT jhendrixMSFT merged commit 7f9667d into Azure:master Jul 19, 2018
jhendrixMSFT added a commit that referenced this pull request Jul 19, 2018
@jhendrixMSFT
Revert "Add API for adding external storage account configurations to…
c98713e 
… a web app (#3444)"

This reverts commit 7f9667d.
@jhendrixMSFT jhendrixMSFT mentioned this pull request Jul 19, 2018
Merged
jhendrixMSFT added a commit that referenced this pull request Jul 19, 2018
@jhendrixMSFT
Revert "Add API for adding external storage account configurations to…
309a7d5 
… a web app (#3444)" (#3449)

This reverts commit 7f9667d.
@ebencarek ebencarek mentioned this pull request Jul 19, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ebencarek @AutorestCI @jhendrixMSFT