Enable Computer Vision Client to customize endpoint. by yangyuan · Pull Request #3440 · Azure/azure-rest-api-specs

yangyuan · 2018-07-18T19:18:02Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-07-18T19:18:46Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2978

AutorestCI · 2018-07-18T19:19:03Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2901

AutorestCI · 2018-07-18T19:20:10Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2237

AutorestCI · 2018-07-18T19:21:03Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1403

AutorestCI · 2018-07-18T19:22:04Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2282

yangyuan · 2018-07-18T19:26:50Z

  package-name: azure-cognitiveservices-computervision
  package-version: 2.0.0-preview
  output-folder: $(node-sdks-folder)/lib/services/computerVision
-  override-client-name: ComputerVisionAPIClient


Remove "override-client-name" since the Client name now naturally ends with "Client"

yangyuan · 2018-07-18T19:36:09Z

    "parameters": [
      {
-        "$ref": "#/parameters/AzureRegion"
+        "$ref": "#/parameters/Endpoint"


Endpoint has to be "$ref", otherwise, it behaves like "x-ms-parameter-location": "method".

I believe you'll have to update all the examples, (like this).

@cthrash Thanks, didn't know about the examples, they are now updated.

cthrash

lgtm

sergey-shandar · 2018-07-19T17:42:27Z

@DavidLiCIG @felixwa please, review.

sergey-shandar

@yangyuan what's the reason for breaking changes in the stable API?

yangyuan · 2018-07-19T17:50:34Z

@sergey-shandar, no changes on operations/models. Just host template update so the client can be flexible to customize the base URI.

DavidLiCIG · 2018-07-19T22:56:54Z

-      "description": "Supported Azure regions for Cognitive Services endpoints",
+    "Endpoint": {
+      "name": "Endpoint",
+      "description": "Supported Cognitive Services endpoints",


This is fine for now but would be great if there is a URL in here pointing users to a doc where he/she would be able to get the endpoint.

yangyuan · 2018-07-20T16:34:29Z

@sergey-shandar ping... :)

sergey-shandar

This's still potential SDK breaking changes. If you are ok with this, I will merge it.

yangyuan · 2018-07-21T00:00:36Z

@sergey-shandar, we are aware that this is a breaking change. :) Please merge.

)" This reverts commit 6a7eb1d.

* Revert "Enable Computer Vision Client to customize endpoint. (#3440)" This reverts commit 6a7eb1d. * Revert "Update custom image search Node.js properties (#3470)" This reverts commit eddee65. * Revert "updated description of sku name values (#3467)" This reverts commit aa50b23.

* Enable Computer Vision Client to customize endpoint. * Update Corresponding examples.

Enable Computer Vision Client to customize endpoint.

d796a07

AutorestCI mentioned this pull request Jul 18, 2018

[AutoPR cognitiveservices/data-plane/ComputerVision] Enable Computer Vision Client to customize endpoint. Azure/azure-sdk-for-python#2951

Merged

AutorestCI mentioned this pull request Jul 18, 2018

[AutoPR cognitiveservices/data-plane/ComputerVision] Enable Computer Vision Client to customize endpoint. Azure/azure-sdk-for-node#3193

Merged

azuresdkci assigned sergey-shandar Jul 18, 2018

azuresdkci requested a review from sergey-shandar July 18, 2018 19:19

AutorestCI mentioned this pull request Jul 18, 2018

[AutoPR cognitiveservices/data-plane/ComputerVision] Enable Computer Vision Client to customize endpoint. Azure/azure-sdk-for-go#2257

Merged

yangyuan commented Jul 18, 2018

View reviewed changes

yangyuan requested a review from cthrash July 18, 2018 19:30

yangyuan commented Jul 18, 2018

View reviewed changes

Update Corresponding examples.

0208d93

cthrash approved these changes Jul 18, 2018

View reviewed changes

sergey-shandar added the potential-sdk-breaking-change label Jul 19, 2018

sergey-shandar requested review from DavidLiCIG and felixwa July 19, 2018 17:41

sergey-shandar reviewed Jul 19, 2018

View reviewed changes

DavidLiCIG reviewed Jul 19, 2018

View reviewed changes

DavidLiCIG approved these changes Jul 19, 2018

View reviewed changes

felixwa approved these changes Jul 19, 2018

View reviewed changes

sergey-shandar approved these changes Jul 20, 2018

View reviewed changes

sergey-shandar merged commit 6a7eb1d into Azure:master Jul 20, 2018

tfitzmac added a commit to tfitzmac/azure-rest-api-specs that referenced this pull request Jul 23, 2018

Revert "Enable Computer Vision Client to customize endpoint. (Azure#3440

d3247e6

)" This reverts commit 6a7eb1d.

This was referenced Jul 23, 2018

Remove basePath from Computer Vision 2.0 examples. #3479

Merged

Update ComputerVision C# SDK auto-generated code. Azure/azure-sdk-for-net#4579

Merged

Cognitive Services URL template (endpoint) #3489

Closed

thang911 pushed a commit to thang911/azure-rest-api-specs that referenced this pull request Aug 17, 2018

Enable Computer Vision Client to customize endpoint. (Azure#3440)

e26d7c2

* Enable Computer Vision Client to customize endpoint. * Update Corresponding examples.

Conversation

yangyuan commented Jul 18, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

yangyuan Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

yangyuan Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

cthrash Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

yangyuan Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

cthrash left a comment

Choose a reason for hiding this comment

Uh oh!

sergey-shandar commented Jul 19, 2018

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

yangyuan commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidLiCIG Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

yangyuan commented Jul 20, 2018

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

yangyuan commented Jul 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yangyuan commented Jul 18, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 18, 2018 •

edited

Loading

AutorestCI commented Jul 18, 2018 •

edited

Loading

AutorestCI commented Jul 18, 2018 •

edited

Loading

AutorestCI commented Jul 18, 2018 •

edited

Loading

AutorestCI commented Jul 18, 2018 •

edited

Loading

yangyuan commented Jul 19, 2018 •

edited

Loading

yangyuan commented Jul 21, 2018 •

edited

Loading