Skip to content

Inbound NAT pools PowerShell changes.#973

Merged
stankovski merged 5 commits intoAzure:devfrom
ankurchoubeymsft:dev
Sep 30, 2015
Merged

Inbound NAT pools PowerShell changes.#973
stankovski merged 5 commits intoAzure:devfrom
ankurchoubeymsft:dev

Conversation

@ankurchoubeymsft
Copy link
Copy Markdown
Contributor

@ankurchoubeymsft ankurchoubeymsft commented Sep 24, 2015

PowerShell commands and model changes for configuring inbound NAT pools on the load balancer. Test cases for inbound NAT pools and their corresponding SessionRecords. Updating package version for Microsoft.Azure.Management.Network. Fixed a few minor typos.

@ankurchoubeymsft
Inbound NAT pools PowerShell changes.
4019f0b 
PowerShell commands and model changes for configuring inbound NAT pools on the load balancer. Test cases for inbound NAT pools and their corresponding SessionRecords. Updating package version for Microsoft.Azure.Management.Network. Fixed a few minor typos.
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 24, 2015

Can one of the admins verify this patch?

@azurecla
Copy link
Copy Markdown

azurecla commented Sep 24, 2015

Hi @ankurchoubeymsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Sep 25, 2015

@azuresdkci add to whitelist

@DeepakRajendranMsft
Copy link
Copy Markdown
Contributor

DeepakRajendranMsft commented Sep 25, 2015

can we kick off the job again, seems to be a test timeout issue in azure backup
D:\workspace\powershell\AzurePowershell.test.targets(100,5): error : XUnit tests in assembly "Microsoft.Azure.Commands.AzureBackup.Test.dll" failed or timed out. Ensure that all tests in a project pass and collectively take less than 1 minute to run. [D:\workspace\powershell\build.proj]

@stankovski
Copy link
Copy Markdown
Member

stankovski commented Sep 29, 2015

@azuresdkci retest this please

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 29, 2015

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Sep 29, 2015

Can one of the admins verify this patch?

stankovski
stankovski reviewed Sep 29, 2015
View reviewed changes
src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/LoadBalancerTests.ps1 Outdated
Copy link
Copy Markdown
Member

@stankovski stankovski Sep 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: cmdlets should be AzureRmXXX

Copy link
Copy Markdown
Contributor Author

@ankurchoubeymsft ankurchoubeymsft Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit. (ankurchoubeymsft@e6cb77a)

@ankurchoubeymsft
Copy link
Copy Markdown
Contributor Author

ankurchoubeymsft commented Sep 30, 2015

Addressed code review comments. New build succeeded and all tests passed. Can one of the admins retest/verify the pull request.

stankovski added a commit that referenced this pull request Sep 30, 2015
@stankovski
Merge pull request #973 from ankurchoubeymsft/dev
cbd9c6d 
Inbound NAT pools PowerShell changes.
@stankovski stankovski merged commit cbd9c6d into Azure:dev Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ankurchoubeymsft @azuresdkci @azurecla @markcowl @DeepakRajendranMsft @stankovski