Skip to content

Bug Fixes in Get-AzureRMRoleAssignment and Delete-AzureRMRoleAssignment#909

Merged
ogail merged 8 commits intoAzure:devfrom
shuagarw:BugFixFilterDeletedRA
Sep 15, 2015
Merged

Bug Fixes in Get-AzureRMRoleAssignment and Delete-AzureRMRoleAssignment#909
ogail merged 8 commits intoAzure:devfrom
shuagarw:BugFixFilterDeletedRA

Conversation

@shuagarw
Copy link
Copy Markdown
Contributor

Bug Fixes in Get-AzureRMRoleAssignment and Delete-AzureRMRoleAssignment

  • Filter roleAssignments for deleted principals.
  • Fix parameter sets for Remove role assignment cmdlet.
  • Fix remove role assignment conditions to fetch at most 1 role Assignment to delete at exact scope.

@azurecla
Copy link
Copy Markdown

Hi @shuagarw, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (shuagarw). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link
Copy Markdown

Can one of the admins verify this patch?

@ogail
Copy link
Copy Markdown
Contributor

ogail commented Sep 15, 2015

@azuresdkci add to whitelist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this excludeAssignmentsForDeletedPrincipals to FilterRoleAssignmentsOptions class instead of a parameter.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

ogail added a commit that referenced this pull request Sep 15, 2015
Bug Fixes in Get-AzureRMRoleAssignment and Delete-AzureRMRoleAssignment
@ogail ogail merged commit 6c61e03 into Azure:dev Sep 15, 2015
@shuagarw shuagarw deleted the BugFixFilterDeletedRA branch September 15, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants