Skip to content

Warn users of impending removal of deployment parameters from New-Azu…#814

Merged
jianghaolu merged 5 commits intoAzure:devfrom
vivsriaus:WarnDeploymentRG
Aug 31, 2015
Merged

Warn users of impending removal of deployment parameters from New-Azu…#814
jianghaolu merged 5 commits intoAzure:devfrom
vivsriaus:WarnDeploymentRG

Conversation

@vivsriaus
Copy link
Copy Markdown
Contributor

@vivsriaus vivsriaus commented Aug 28, 2015

…reResourceGroup

@azurecla
Copy link
Copy Markdown

azurecla commented Aug 28, 2015

Hi @vivsriaus, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (visriniv). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@ogail
Copy link
Copy Markdown
Contributor

ogail commented Aug 28, 2015

On demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/152/

@vivsriaus
Copy link
Copy Markdown
Contributor Author

vivsriaus commented Aug 28, 2015

@ogail Looks like a compute test is failing. Can we please ask them to fix it?

markcowl
markcowl reviewed Aug 29, 2015
View reviewed changes
...er/ResourceManager/Commands.ResourceManager/Cmdlets/Implementation/GetAzureResourceCmdlet.cs Outdated
Copy link
Copy Markdown
Member

@markcowl markcowl Aug 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivsriaus Do not add this - it will actually make the build fail, because we have to turn on treat warnings as errors. Instead, print a messag to the verbose stream when the command is executed if a user uses this parameter

@vivsriaus
Copy link
Copy Markdown
Contributor Author

vivsriaus commented Aug 31, 2015

@markcowl Done. Can you please merge this?

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Aug 31, 2015

@vivsriaus There was an issue with the post check-in build, which was just resolved. For all peninding PRs, we are running the post-checkin build to verify that there are no breaks before merging. Should merge if there are no issues.

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Aug 31, 2015

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/167/

jianghaolu pushed a commit that referenced this pull request Aug 31, 2015
Merge pull request #814 from vivsriaus/WarnDeploymentRG
d6236ba 
Warn users of impending removal of deployment parameters from New-Azu…
@jianghaolu jianghaolu merged commit d6236ba into Azure:dev Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vivsriaus @azurecla @ogail @markcowl @jianghaolu