Skip to content

CSP Artemis#627

Merged
yugangw-msft merged 8 commits intoAzure:devfrom
MabOneSdk:release
Jul 21, 2015
Merged

CSP Artemis#627
yugangw-msft merged 8 commits intoAzure:devfrom
MabOneSdk:release

Conversation

@dragonfly91
Copy link
Copy Markdown

@dragonfly91 dragonfly91 commented Jul 20, 2015

This PR includes the two cmdlets:

  1. Get-AzureBackupContainer
  2. Unregister-AzureBackupContainer

Currently we've committed the BackupServicesManagement.DLL (OneSDK DLL). But, once the corresponding PRs are merged, we'll publish the nuget package and take the dependency on the pkg instead of the DLL.

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Jul 20, 2015

Can one of the admins verify this patch?

@azurecla
Copy link
Copy Markdown

azurecla commented Jul 20, 2015

Hi @dragonfly91, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

yugangw-msft
yugangw-msft reviewed Jul 20, 2015
View reviewed changes
src/ResourceManager/AzureBackup/Commands.AzureBackup/Commands.AzureBackup.csproj Outdated
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft Jul 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct or recommended. Please increase the version number at you pr in azure-sdk-for-net, publish that, and use the new one

Copy link
Copy Markdown
Author

@dragonfly91 dragonfly91 Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also sent another PR for azure-sdk-for-net. Once that PR is merged, I will publish the nuget and take dependency on the nuget instead of this DLL. In the meanwhile, can you please continue with the review?

@yugangw-msft
Copy link
Copy Markdown
Contributor

yugangw-msft commented Jul 21, 2015

add to whitelist

yugangw-msft added a commit that referenced this pull request Jul 21, 2015
@yugangw-msft
Merge pull request #627 from MabOneSdk/release
29f3208 
CSP Artemis
@yugangw-msft yugangw-msft merged commit 29f3208 into Azure:dev Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dragonfly91 @azuresdkci @azurecla @yugangw-msft