Skip to content

AzureRT PR#417

Merged
ogail merged 10 commits intoAzure:devfrom
hyonholee:dev2
May 22, 2015
Merged

AzureRT PR#417
ogail merged 10 commits intoAzure:devfrom
hyonholee:dev2

Conversation

@hyonholee
Copy link
Copy Markdown
Contributor

  • Combine Get-AzureVMImage and Get-AzureVMImageDetail
  • Combine Get-AzureVMExtensionImage and Get-AzureVMExtensionImageDetail
  • Fix piping issue of Remove-AzureVMDataDisk and Remove-AzureVMNetworkInterface
  • Update the ouput of Remove-AzureAvailabilitySet
  • Add Force parameter for Remove-AzureAvailabilitySet

@azurecla
Copy link
Copy Markdown

Hi @hyonholee, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (hylee). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hyonholee hyonholee changed the title This PR contains the following updates AzureRT PR May 22, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's duplicate, and please use the following one:

    public class PSOperation
    {
        public string RequestId { get; set; }

        public HttpStatusCode StatusCode { get; set; }
    }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of child class of PSOperation, so if you use PSOperation and format it, all other cmdlets are affected, and show a wrong format. That is why I created a new class.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know what's the specific wrong format about? If something is wrong, it's better to fix it correctly, isn't it?

@huangpf
Copy link
Copy Markdown
Contributor

huangpf commented May 22, 2015

I have concerns about Fix piping issue of Remove-AzureVMDataDisk and Remove-AzureVMNetworkInterface, and I suggest we don't patch this in this sprint. Other than that LGTM.

@markcowl
Copy link
Copy Markdown
Member

@huangpf, is this ready to be considered for merge?

@markcowl
Copy link
Copy Markdown
Member

@azuresdkci retest this please

ogail added a commit that referenced this pull request May 22, 2015
@ogail ogail merged commit bcf0742 into Azure:dev May 22, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string[]

huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Feb 23, 2016
HPF PR: vmss <- huangpf:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants