Skip to content

Adding SQL AutoDR support#1862

Merged
markcowl merged 4 commits intoAzure:devfrom
franktsa:dev
Feb 25, 2016
Merged

Adding SQL AutoDR support#1862
markcowl merged 4 commits intoAzure:devfrom
franktsa:dev

Conversation

@franktsa
Copy link
Copy Markdown
Contributor

@franktsa franktsa commented Feb 24, 2016

Adding support for AutoDr functionality, which is a configuration object under the server. Operations include:
•Create (PUT)
•Read (GET)
•Update / Failover (POST)
•Delete (DELETE)

CR: http://codeflow/dashboard/review/display/franktsa-c410159bf86f4ca8b7a9f2c6b5768b9f

@azurecla
Copy link
Copy Markdown

azurecla commented Feb 24, 2016

Hi @franktsa, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (franktsa). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

hovsepm
hovsepm reviewed Feb 25, 2016
View reviewed changes
...urceManager/Sql/Commands.Sql.Test/ScenarioTests/ServerDisasterRecoveryConfigurationTests.ps1 Outdated

try
{
$server1 = Create-ServerForTest $rg1 "12.0" $location1
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franktsa please align indentation. Replace tab with 4 spaces in the file.

@franktsa
Feedback response:
c23a66b 
- Replaced tabs with spaces in test file
- Removed Authentication reference in packages.config
@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Feb 25, 2016

on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/543/

hovsepm
hovsepm reviewed Feb 25, 2016
View reviewed changes
src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj Outdated
<HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Azure.Common.Authentication">
<HintPath>..\..\..\packages\Microsoft.Azure.Common.Authentication.1.4.1-preview\lib\net45\Microsoft.Azure.Common.Authentication.dll</HintPath>
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this. You need to reference solution in the repo

@franktsa
Feedback response:
5988d4b 
- Removed reference to Microsoft.WindowsAzure.ConfigurationManager
@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Feb 25, 2016

new on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/545/

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Feb 25, 2016

@hovsepm @franktsa The common.authentication reference still needs to be removed

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Feb 25, 2016

last on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/546/

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Feb 25, 2016

@franktsa What are the plans for adding help for these cmdlets? Also, can you please send a PR with updates to the ChangeLog for these cmdlets?

markcowl added a commit that referenced this pull request Feb 25, 2016
@markcowl
Merge pull request #1862 from franktsa/dev
6ca1bef 
Adding SQL AutoDR support
@markcowl markcowl merged commit 6ca1bef into Azure:dev Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@franktsa @azurecla @hovsepm @markcowl @fhljys