Fix module's dependency#17824
Merged
dingmeng-xue merged 5 commits intoAzure:internal/predictorfrom Apr 28, 2022
Merged
Conversation
dingmeng-xue
approved these changes
Apr 28, 2022
wyunchi-ms
pushed a commit
that referenced
this pull request
Apr 29, 2022
* Fix module's dependency (#17824) * Update the external dependenct modules * update the packages to GA version * Exclude contentFiles in the out directory * Remove Az as the external dependent module * Format the csproj file. * update files Co-authored-by: kceiw <mahuang@microsoft.com>
VeryEarly
pushed a commit
that referenced
this pull request
Sep 24, 2022
* Fix module's dependency (#17824) * Update the external dependenct modules * update the packages to GA version * Exclude contentFiles in the out directory * Remove Az as the external dependent module * Format the csproj file. * update files * Release Az.Tools.Predictor 1.0.2 * Update Az.Tools.Predictor.csproj * Update Az.Tools.Predictor.psd1 Co-authored-by: kceiw <mahuang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are a few changes in this PR.
RequiredModulesare automatically installed when Az.Tools.Predictor is installed. This is done via clearing theExternalModuleDependencies. We already set theRequiredModules. SettingExternalModuleDependencieswith the same content confuses PowerShell not to installRequiredModulesautomatically.Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added