Azure Logic App PowerShell Cmdlets by pankajsn · Pull Request #1753 · Azure/azure-powershell

pankajsn · 2016-01-30T00:51:58Z

This pull request contains the Azure Logic App PowerShell Cmdlets implementation which introduces following cmdlets:

Stop-AzureLogicAppRun
Get-AzureLogicAppAccessKey
Get-AzureLogicApp
Get-AzureLogicAppRunAction
Get-AzureLogicAppRunHistory
Get-AzureLogicAppTrigger
Get-AzureLogicAppTriggerHistory
New-AzureLogicApp
Remove-AzureLogicApp
Start-AzureLogicApp
Set-AzureLogicAppAccessKey
Set-AzureLogicApp

Also, includes: Test Automation, Installer Setup Update, Help Documentation, ps1xml

…with Installer and PowerShell help included.

Cmdlets Help Installer Changes Test Automation ps1xml Output Format Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>

# Conflicts: # setup/azurecmdfiles.wxi # src/ResourceManager/LogicApp/Commands.LogicApp.Test/Commands.LogicApp.Test.csproj # src/ResourceManager/LogicApp/Commands.LogicApp.Test/UnitTests/CreateLogicAppTests.cs # src/ResourceManager/LogicApp/Commands.LogicApp.Test/packages.config # src/ResourceManager/LogicApp/Commands.LogicApp/Commands.LogicApp.csproj # src/ResourceManager/LogicApp/Commands.LogicApp/packages.config # src/ResourceManager/LogicApp/LogicApp.sln

Removed App.config in Test project Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>

Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>

azuresdkci · 2016-01-30T00:51:59Z

Can one of the admins verify this patch?

azurecla · 2016-01-30T00:52:06Z

Hi @pankajsn, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (pankajsn). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

hovsepm · 2016-01-30T03:45:27Z

@azuresdkci add to whitelist

# Conflicts: # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowAccessKeyTests/TestGetAzureLogicAppAccessKey.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowAccessKeyTests/TestSetAzureLogicAppAccessKey.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowRunTests/TestGetAzureLogicAppRunAction.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowRunTests/TestGetAzureLogicAppRunHistory.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowRunTests/TestRunLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateAndGetLogicAppUsingDefinitionWithActions.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateAndRemoveLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppUsingDefinitionWithTriggers.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppUsingInputParameterAsHashTable.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppUsingInputfromWorkflowObject.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppWithDuplicateName.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppWithNonExistingAppServicePlan.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestRemoveNonExistingLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestUpdateLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTriggerTests/TestGetAzureLogicAppTrigger.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTriggerTests/TestGetAzureLogicAppTriggerHistory.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTriggerTests/TestStartAzureLogicAppTrigger.json

pankajsn · 2016-01-30T21:19:56Z

azurecmdfiles.wxi file got messed up during merge. File is fixed and committed now.

Updated Readme.md and ChangeLog.md with cmdlets description.

pankajsn · 2016-01-31T04:37:33Z

AzurePowerShell.Test.targets updated for test integration.
Updated Readme.md and ChangeLog.md with cmdlets description.

markcowl · 2016-02-01T21:55:43Z

README.md

Please remove, we are no longer updating the README for new RPs

[Fixed] : Section removed from the Readme.md

From: Mark Cowlishaw [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 1:56 PM
To: Azure/azure-powershell azure-powershell@noreply.github.com
Cc: Pankaj Singh Negi Pankaj.Negi@microsoft.com
Subject: Re: [azure-powershell] Azure Logic App PowerShell Cmdlets (#1753)

In README.mdhttps://github.com//pull/1753#discussion_r51487428:

@@ -119,6 +119,11 @@ This repository contains a set of PowerShell cmdlets for developers and administ

Azure Automation

Manage automation accounts

Manage automation jobs, runbooks and schedules

+* Logic Apps

Please remove, we are no longer updating the README for new RPs

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1753/files#r51487428.

AzureRM.Profile version corrected to 1.0.3 Removed content from Readme.md Removed unused reference from Test Project AssemblyInfo added

hovsepm · 2016-02-01T23:21:44Z

ChangeLog.md

Your changes will not go out as part of February release. Please add a new tag

2016.03.08 version 1.3.0

and then add your change log text.

[Fixed]: Moved to new section as suggested. Below tag indicates next release in March. I just want to know, What is the process if we want to release these changes early?

From: Hovsep [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 3:22 PM
To: Azure/azure-powershell azure-powershell@noreply.github.com
Cc: Pankaj Singh Negi Pankaj.Negi@microsoft.com
Subject: Re: [azure-powershell] Azure Logic App PowerShell Cmdlets (#1753)

In ChangeLog.mdhttps://github.com//pull/1753#discussion_r51498279:

@@ -1,5 +1,18 @@

2016.02.02 version 1.1.1

Azure RemoteApp: Organizational Unit in Azure RemoteApp RDFE cmdlets now accepts Unicode characters.

+* Azure LogicApp: New cmdlets for managing LogicApps

Get-AzureLogicAppAccessKey

Get-AzureLogicApp

Get-AzureLogicAppRunAction

Get-AzureLogicAppRunHistory

Get-AzureLogicAppTrigger

Get-AzureLogicAppTriggerHistory

New-AzureLogicApp

Remove-AzureLogicApp

Start-AzureLogicApp

Set-AzureLogicAppAccessKey

Set-AzureLogicApp

Stop-AzureLogicAppRun

Your changes will not go out as part of February release. Please add a new tag

2016.03.08 version 1.3.0

and then add your change log text.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1753/files#r51498279.

hovsepm · 2016-02-01T23:31:21Z

@pankajsn all the cmdlet names should follow [Verb]-AzureRM[prefix][noun] naming. Please fix.

-Cmdlet name fixed as per naming convention -Assembly version fixed -snk file removed from test -ChangeLog.md file updated

pankajsn · 2016-02-02T04:38:21Z

[Fixed]

Get-AzureLogicAppAccessKey >> Get-AzureRmLogicAppAccessKey
Get-AzureLogicApp >> Get-AzureRmLogicApp
Get-AzureLogicAppRunAction >> Get-AzureRmLogicAppRunAction
Get-AzureLogicAppRunHistory >> Get-AzureRmLogicAppRunHistory
Get-AzureLogicAppTrigger >> Get-AzureRmLogicAppTrigger
New-AzureLogicApp >> New-AzureRmLogicApp
Remove-AzureLogicApp >> Remove-AzureRmLogicApp
Start-AzureLogicApp >> Start-AzureRmLogicApp
Set-AzureLogicAppAccessKey >> Set-AzureRmLogicAppAccessKey
Set-AzureLogicApp >> Set-AzureRmLogicApp
Stop-AzureLogicAppRun >> Stop-AzureRmLogicAppRun
Get-AzureLogicAppTriggerHistory >> Get-AzureRmLogicAppTriggerHistory

From: Hovsep [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 3:32 PM
To: Azure/azure-powershell azure-powershell@noreply.github.com
Cc: Pankaj Singh Negi Pankaj.Negi@microsoft.com
Subject: Re: [azure-powershell] Azure Logic App PowerShell Cmdlets (#1753)

@pankajsnhttps://github.com/pankajsn all the cmdlet names should follow [Verb]-AzureRM[prefix][noun] naming. Please fix.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1753#issuecomment-178254062.

pcgeek86 · 2016-02-02T10:30:05Z

@pankajsn @hovsepm Thanks for ensuring naming standards. Are we also ensuring that there is detailed cmdlet help before they are released, please?

Cheers,
Trevor Sullivan

pankajsn · 2016-02-02T14:18:19Z

Yes, Detailed cmdlet help is in place.

Regards,
~Pankaj

Sent from my Windows Phone

From: Trevor Sullivanmailto:notifications@github.com
Sent: ‎2/‎2/‎2016 2:30
To: Azure/azure-powershellmailto:azure-powershell@noreply.github.com
Cc: Pankaj Singh Negimailto:Pankaj.Negi@microsoft.com
Subject: Re: [azure-powershell] Azure Logic App PowerShell Cmdlets (#1753)

@pankajsnhttps://github.com/pankajsn @hovsepmhttps://github.com/hovsepm Thanks for ensuring naming standards. Are we also ensuring that there is detailed cmdlet help before they are released, please?

Cheers,
Trevor Sullivan

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1753#issuecomment-178499488.

hovsepm · 2016-02-04T01:52:57Z

@pankajsn Please pull from upstream dev and resolve conflicts.

Conflicts: ChangeLog.md setup/azurecmdfiles.wxi

Conflicts: setup/azurecmdfiles.wxi

Removed InternalvisibleTo attribute as not needed

Azure Logic App PowerShell Cmdlets

pankajsn added 9 commits December 22, 2015 10:50

New-AzureLogicApp PowerShell command with unittest and scenario test …

ba36f84

…with Installer and PowerShell help included.

Set, Get, Remove PowerShell commands added.

ca4be2f

Azure Logic App PS cmdlets

4d88a9c

Cmdlets Help Installer Changes Test Automation ps1xml Output Format Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>

Merge remote-tracking branch 'refs/remotes/origin/dev' into Azure/dev

1dbf111

Merged with the latest code from GIT Repo

98080ab

Regenerated Session records with latest Test run.

9fbe613

Removed App.config in Test project Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>

App.config removed

02e6cab

Session records updated with latest test run.

90ced65

Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>

azurecla added the cla-not-required label Jan 30, 2016

pankajsn added 2 commits January 30, 2016 12:16

Wxi file fixed.

8487c01

AzurePowerShell.Test.targets updated for test integration.

1f6c3fb

Updated Readme.md and ChangeLog.md with cmdlets description.

Merge remote-tracking branch 'refs/remotes/origin/dev' into Azure/dev

c4da092

markcowl reviewed Feb 1, 2016
View reviewed changes

Code review comments fixed.

fbeaf6f

AzureRM.Profile version corrected to 1.0.3 Removed content from Readme.md Removed unused reference from Test Project AssemblyInfo added

hovsepm reviewed Feb 1, 2016
View reviewed changes

Code review comments fixed [Hovsep]

e96d655

-Cmdlet name fixed as per naming convention -Assembly version fixed -snk file removed from test -ChangeLog.md file updated

pankajsn added 4 commits February 4, 2016 15:45

Merge remote-tracking branch 'upstream/dev' into dev

73692cd

Conflicts: ChangeLog.md setup/azurecmdfiles.wxi

Merge remote-tracking branch 'upstream/dev' into dev

85f4830

Conflicts: setup/azurecmdfiles.wxi

AssemblyInfo fixed

6195ff4

Removed InternalvisibleTo attribute as not needed

Resolved merge conflicts

286947b

hovsepm pushed a commit that referenced this pull request Feb 6, 2016

Merge pull request #1753 from pankajsn/dev

4283073

Azure Logic App PowerShell Cmdlets

hovsepm merged commit 4283073 into Azure:dev Feb 6, 2016

Conversation

pankajsn commented Jan 30, 2016

Uh oh!

azuresdkci commented Jan 30, 2016

Uh oh!

azurecla commented Jan 30, 2016

Uh oh!

hovsepm commented Jan 30, 2016

Uh oh!

pankajsn commented Jan 30, 2016

Uh oh!

pankajsn commented Jan 31, 2016

Uh oh!

markcowl Feb 1, 2016

Choose a reason for hiding this comment

Uh oh!

pankajsn Feb 1, 2016

Choose a reason for hiding this comment

Uh oh!

hovsepm Feb 1, 2016

Choose a reason for hiding this comment

2016.03.08 version 1.3.0

Uh oh!

pankajsn Feb 2, 2016

Choose a reason for hiding this comment

2016.02.02 version 1.1.1

Uh oh!

hovsepm commented Feb 1, 2016

Uh oh!

pankajsn commented Feb 2, 2016

Uh oh!

pcgeek86 commented Feb 2, 2016

Uh oh!

pankajsn commented Feb 2, 2016

Uh oh!

hovsepm commented Feb 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants