Skip to content

Add Opt-out for DSC Extension DataCollection#1749

Merged
hovsepm merged 4 commits intorelease-1.2.0from
unknown repository
Jan 29, 2016
Merged

Add Opt-out for DSC Extension DataCollection#1749
hovsepm merged 4 commits intorelease-1.2.0from
unknown repository

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Jan 29, 2016

@azurecla
Copy link
Copy Markdown

azurecla commented Jan 29, 2016

Hi @TravisEz13, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (tplunk). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

huangpf
huangpf reviewed Jan 29, 2016
View reviewed changes
src/ResourceManager/Compute/Commands.Compute/Extension/DSC/SetAzureVMDscExtensionCommand.cs
Copy link
Copy Markdown
Contributor

@huangpf huangpf Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it should be using SwitchParameter.

Copy link
Copy Markdown
Member Author

@TravisEz13 TravisEz13 Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need three states enable, disable and not specified. a switch parameter does not allow all three states, or possible future states.

Copy link
Copy Markdown
Contributor

@huangpf huangpf Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks.

@huangpf
Copy link
Copy Markdown
Contributor

huangpf commented Jan 29, 2016

Looks OK to me.

huangpf
huangpf reviewed Jan 29, 2016
View reviewed changes
...eManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/SetAzureVMDscExtension.cs
Copy link
Copy Markdown
Contributor

@huangpf huangpf Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it should be using SwitchParameter.

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Jan 29, 2016

on-demand: http://azuresdkci.cloudapp.net/job/powershell-demand/470/

@hyonholee
Copy link
Copy Markdown
Contributor

hyonholee commented Jan 29, 2016

LGTM. Thanks.

hovsepm pushed a commit that referenced this pull request Jan 29, 2016
Merge pull request #1749 from dscsolutions/DataCollectionRb2
d3e43d0 
Add Opt-out for DSC Extension DataCollection
@hovsepm hovsepm merged commit d3e43d0 into Azure:release-1.2.0 Jan 29, 2016
@eshaparmar eshaparmar deleted the DataCollectionRb2 branch March 15, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TravisEz13 @azurecla @huangpf @hovsepm @hyonholee