Skip to content

Ability to parse "Tokens" in SetParameters file as per release management#1673

Merged
markcowl merged 4 commits intoAzure:devfrom
aneillans:dev
Feb 18, 2016
Merged

Ability to parse "Tokens" in SetParameters file as per release management#1673
markcowl merged 4 commits intoAzure:devfrom
aneillans:dev

Conversation

@aneillans
Copy link
Copy Markdown
Contributor

@aneillans aneillans commented Jan 18, 2016

As a first step to add support for tokenisation of parameters files, as per the current release management method for abstracting configuration between environments, this change allows passing of Tokens to the Publish command which are then parsed and updated in the SetParameters file, ready to be consumed by WebDeploy.

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Jan 18, 2016

Can one of the admins verify this patch?

@azurecla
Copy link
Copy Markdown

azurecla commented Jan 18, 2016

Hi @aneillans, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

hovsepm
hovsepm reviewed Jan 19, 2016
View reviewed changes
src/ServiceManagement/Services/Commands/Websites/PublishAzureWebsiteProject.cs Outdated
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Jan 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aneillans Please use Path.Combine instead of manual path creation.

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Jan 19, 2016

@aneillans Please sign the CLA so we can accept your changes.

@aneillans
Copy link
Copy Markdown
Contributor Author

aneillans commented Jan 20, 2016

The cla site is broken :(

Will make the changes

Sent from my iPhone

On 19 Jan 2016, at 23:18, Hovsep notifications@github.com wrote:

@aneillans Please sign the CLA so we can take in your changes.

—
Reply to this email directly or view it on GitHub.

@azurecla
Copy link
Copy Markdown

azurecla commented Jan 20, 2016

@aneillans, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, AZPRBOT;

@aneillans
Copy link
Copy Markdown
Contributor Author

aneillans commented Jan 20, 2016

Updated applied to use Path.Combine

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Jan 22, 2016

@azuresdkci test this please

@aneillans
Copy link
Copy Markdown
Contributor Author

aneillans commented Jan 30, 2016

Any updates on if this will be accepted?

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Feb 4, 2016

@aneillans I've contacted owner team to take a look to your PR.

@hovsepm hovsepm added the App Services aka WebSites label Feb 4, 2016
@hovsepm hovsepm assigned chadiel and unassigned chadiel Feb 4, 2016
@akurmi
Copy link
Copy Markdown
Contributor

akurmi commented Feb 18, 2016

Approved

markcowl added a commit that referenced this pull request Feb 18, 2016
@markcowl
Merge pull request #1673 from aneillans/dev
bfcb8a4 
Ability to parse "Tokens" in SetParameters file as per release management
@markcowl markcowl merged commit bfcb8a4 into Azure:dev Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

App Services aka WebSites

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aneillans @azuresdkci @azurecla @hovsepm @akurmi @markcowl @chadiel