Skip to content

Fixed CLU issue with ValidateElement when the object is not a string or enum.#1513

Merged
hovsepm merged 5 commits intoAzure:clufrom
hovsepm:clu
Dec 18, 2015
Merged

Fixed CLU issue with ValidateElement when the object is not a string or enum.#1513
hovsepm merged 5 commits intoAzure:clufrom
hovsepm:clu

Conversation

@hovsepm
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm commented Dec 17, 2015

No description provided.

@markcowl
Copy link
Copy Markdown
Member

@johanste can you take a look?

@johanste
Copy link
Copy Markdown
Member

For value types other than enum, we really should pass in the correct (invariant) culture when calling ToString.

Best regards,
Johan

From: Mark Cowlishaw [mailto:notifications@github.com]
Sent: Thursday, December 17, 2015 1:31 PM
To: Azure/azure-powershell azure-powershell@noreply.github.com
Cc: Johan Stenberg Johan.Stenberg@microsoft.com
Subject: Re: [azure-powershell] Fixed CLU issue with ValidateElement when the object is not a string or enum. (#1513)

@johanstehttps://github.com/johanste can you take a look?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1513#issuecomment-165586673.

@hovsepm
Copy link
Copy Markdown
Contributor Author

hovsepm commented Dec 18, 2015

@johanste addressed feedback. Also added version bump up to this PR (actually done by mistake, but I think it can go along with these changes).

@hovsepm
Copy link
Copy Markdown
Contributor Author

hovsepm commented Dec 18, 2015

now have to bring other changes since the Nuget packages were bumped up.

hovsepm pushed a commit that referenced this pull request Dec 18, 2015
Fixed CLU issue with ValidateElement when the object is not a string or enum.
@hovsepm hovsepm merged commit 651f2f6 into Azure:clu Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants