Updated Connection monitor endpoint cmdlet#12852
Updated Connection monitor endpoint cmdlet#12852irrogozh wants to merge 4 commits intoAzure:masterfrom irrogozh:master
Conversation
|
@irrogozh Please fix the compilation error https://dev.azure.com/azure-sdk/29ec6040-b234-4e31-b139-33dc4287b756/_apis/build/builds/524719/logs/23 |
|
cmdlet review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/733 @irrogozh Can this PR be closed since it is duplicate with #12851 |
|
@msJinLei , no, actually this pr should be the main one. We can close pr in network-june branch |
There was a problem hiding this comment.
Add mandatory parameter is a breaking change.
- add breaking change notification to master first
- release your breaking change in major release in Oct.
There was a problem hiding this comment.
@msJinLei , we discussed that it's not necessary, because the feature is in Public preview:( Not in GA. We need it to be in this release for Ignite.
There was a problem hiding this comment.
@msJinLei , we discussed that it's not necessary, because the feature is in Public preview:( Not in GA. We need it to be in this release for Ignite.
The PR is targeting to master branch, in which breaking change is not allowed.
- If you want to release these breaking change features. we can release it with a OOB release rather than next regular release. You need to create a preview branch (or with an existing branch) to include this PR and request for a OOB release after next regular release.
- If you want to merge these commits to master, you need wait for the major release.
|
closed since duplicate with #12943 |
Description
Same pr was already reviewed in network-june branch
#12851 (comment)
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added