Updated ConnectionMonitorEndpoint cmdlet by irrogozh · Pull Request #12851 · Azure/azure-powershell

irrogozh · 2020-09-04T01:37:17Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)

Link on design spec: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/733

- [ ] the markdown help files have been regenerated using the commands listed [here](../blob/master/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)

msJinLei · 2020-09-08T03:32:42Z

@irrogozh
Have already submit a cmdlet review here?
Your PR contains a lot of breaking change, which cannot merge to master now.

  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointFilterItemObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject","0","1000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' back to the module, or add an alias to the original cmdlet name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterType' and no alias was found for the original parameter name.","Add the parameter 'FilterType' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterItem' and no alias was found for the original parameter name.","Add the parameter 'FilterItem' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByResourceId' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByResourceId' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByAddress' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByAddress' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  
  
  D:\a\1\s\artifacts//StaticAnalysisResults\BreakingChangeIssues.csv:
  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointFilterItemObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject","0","1000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' back to the module, or add an alias to the original cmdlet name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterType' and no alias was found for the original parameter name.","Add the parameter 'FilterType' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterItem' and no alias was found for the original parameter name.","Add the parameter 'FilterItem' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByResourceId' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByResourceId' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByAddress' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByAddress' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."

Let's do the cmdlet review first.

irrogozh · 2020-09-08T03:35:56Z

@msJinLei, I've already submitted design spec for updated cmdlets here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/733
And you even reviewed it

msJinLei · 2020-09-09T06:59:50Z

@msJinLei, I've already submitted design spec for updated cmdlets here: Azure/azure-powershell-cmdlet-review-pr#733
And you even reviewed it

@irrogozh
Sorry not to remember it as review to many things every day.

Version 3.3.0 is not a public review version. What release version do you want to include the changes of this PR?

Please also update the changelog.md understand Network.

//related PR: #12852

msJinLei · 2020-09-10T06:51:38Z

@irrogozh As @MikhailTryakhov asks to delete the network-june branch and create the branch of network-july, can you re-target this PR to network-july or close it?

msJinLei · 2020-09-15T02:29:09Z

closed since duplicate with #12943

irrogozh added 2 commits September 3, 2020 18:34

Updated SDK version

d2f3199

Updated ConnectionMonitorEndpoint cmdlet

954d99f

irrogozh requested a review from MikhailTryakhov as a code owner September 4, 2020 01:37

azuresdkci added the needs-review label Sep 4, 2020

irrogozh added 2 commits September 3, 2020 19:43

Updated help files

004a6dc

Fixed help files

41649c5

msJinLei added Cmdlet Review Required ⚠️ and removed needs-review labels Sep 8, 2020

msJinLei assigned irrogozh Sep 8, 2020

Suppressed breaking changes warnings

8c50bff

msJinLei mentioned this pull request Sep 9, 2020

Updated Connection monitor endpoint cmdlet #12852

Closed

8 tasks

msJinLei added needs-review needs-revision Contains Breaking Change This PR contains breaking change and removed Cmdlet Review Required ⚠️ needs-review labels Sep 9, 2020

msJinLei mentioned this pull request Sep 14, 2020

Updated Connection monitor endpoint cmdlet #12943

Merged

8 tasks

msJinLei self-assigned this Sep 14, 2020

msJinLei closed this Sep 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated ConnectionMonitorEndpoint cmdlet#12851

Updated ConnectionMonitorEndpoint cmdlet#12851
irrogozh wants to merge 5 commits intoAzure:network-junefrom
irrogozh:network-june

irrogozh commented Sep 4, 2020 •

edited

Loading

Uh oh!

msJinLei commented Sep 8, 2020

Uh oh!

irrogozh commented Sep 8, 2020

Uh oh!

msJinLei commented Sep 9, 2020 •

edited

Loading

Uh oh!

msJinLei commented Sep 10, 2020

Uh oh!

msJinLei commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

irrogozh commented Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

msJinLei commented Sep 8, 2020

Uh oh!

irrogozh commented Sep 8, 2020

Uh oh!

msJinLei commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msJinLei commented Sep 10, 2020

Uh oh!

msJinLei commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

irrogozh commented Sep 4, 2020 •

edited

Loading

msJinLei commented Sep 9, 2020 •

edited

Loading