Skip to content

Failover managed instance#12210

Merged
VeryEarly merged 7 commits intoAzure:masterfrom
milanbrkic-ms:failoverManagedInstance
Jun 19, 2020
Merged

Failover managed instance#12210
VeryEarly merged 7 commits intoAzure:masterfrom
milanbrkic-ms:failoverManagedInstance

Conversation

@milanbrkic-ms
Copy link
Copy Markdown
Contributor

@milanbrkic-ms milanbrkic-ms commented Jun 18, 2020

Description

Created new cmdlet for initiating failover on SQL Managed Instance.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Copy Markdown
Collaborator

adxsdkps commented Jun 18, 2020

Can one of the admins verify this patch?

@milanbrkic-ms milanbrkic-ms requested review from ferno-ms and msJinLei and removed request for ferno-ms June 18, 2020 16:11
@milanbrkic-ms
Copy link
Copy Markdown
Contributor Author

milanbrkic-ms commented Jun 18, 2020

Design review is in progress https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/638

@VeryEarly VeryEarly self-assigned this Jun 19, 2020
@VeryEarly VeryEarly merged commit 62f5052 into Azure:master Jun 19, 2020
dingmeng-xue pushed a commit that referenced this pull request Jun 20, 2020
@milanbrkic-ms @MDCS-sql
@VeryEarly @dingmeng-xue
Failover managed instance (#12210)
f921772 
* Initial commit without tests

* with tests

* Recorde Session for Tests and rever csproj files

* Added help md file

* Bump the version

* Update ChangeLog.md

Co-authored-by: Milan Brkic <mibrkic@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@msJinLei msJinLei Awaiting requested review from msJinLei

Assignees

@VeryEarly VeryEarly

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@milanbrkic-ms @adxsdkps @VeryEarly @azuresdkci @MDCS-sql