Skip to content

Az.CognitiveServices - Update SDK to 7.0, Improve error message#10959

Merged
VeryEarly merged 4 commits intomasterfrom
unknown repository
Feb 11, 2020
Merged

Az.CognitiveServices - Update SDK to 7.0, Improve error message#10959
VeryEarly merged 4 commits intomasterfrom
unknown repository

Conversation

@yangyuan
Copy link
Copy Markdown
Member

@yangyuan yangyuan commented Jan 22, 2020

Description

Update SDK to 7.0
Improve error message when server responses empty body

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jan 22, 2020
@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Jan 28, 2020

Hi @yangyuan ,

Your PR looks good to me, could you please format your code in this convention?
Just to improve the readability.

this.CognitiveServicesClient.Accounts.Update(this.ResourceGroupName,
this.Name,
new CognitiveServicesAccount()
{
Properties = properties
});

markcowl
markcowl requested changes Jan 28, 2020
View reviewed changes
@yangyuan
Copy link
Copy Markdown
Member Author

yangyuan commented Feb 4, 2020

@markcowl update the format as suggested :)

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Feb 4, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Feb 4, 2020

Pull request contains merge conflicts.

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Feb 4, 2020

@markcowl update the format as suggested :)

Hi @yangyuan ,

github display my suggested format change in a different way :(

sent you the right one through teams, also please fix the conflicting files

@VeryEarly VeryEarly requested a review from markcowl February 5, 2020 01:36
@VeryEarly VeryEarly merged commit fba96af into Azure:master Feb 11, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@VeryEarly
Merge pull request Azure#10959 from yuanyang-microsoft/yuanyang/async…
9bad7b0 
…_delete

Az.CognitiveServices - Update SDK to 7.0, Improve error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl markcowl approved these changes

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

No one assigned

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yangyuan @VeryEarly @markcowl @anqyan