Make NewAzureDeployment param validation consistent with SetAzureDeploym...#109
Conversation
…oyment - SetAzureDeployment only checks if the CurrentStorageAccount is set if the package needs to be uploaded to storage - NewAzureDeployment always throws if CurrentStorageAccount is set regardless of whether the package needs to be uploaded to storage - This change makes NewAzureDeployment consistent with the behavior of SetAzureDeployment
|
Can one of the admins verify this patch? |
|
Hi @rylewell-msft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
Member
|
@azuresdkci add to whitelist |
ogail
added a commit
that referenced
this pull request
Feb 5, 2015
Make NewAzureDeployment param validation consistent with SetAzureDeploym...
ogail
pushed a commit
that referenced
this pull request
Aug 19, 2015
Fixing bugs of powershell tests and saving recordings except e2e.
AzureRT
referenced
this pull request
in AzureRT/azure-powershell
Sep 28, 2015
ionuttulai
pushed a commit
to ionuttulai/azure-powershell
that referenced
this pull request
Mar 4, 2020
Fixing the Psd1 files for Core Editions and supported Frameworks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Set-AzureDeployment, if the given package Uri is to a file, then it will first upload that file to Azure storage. The storage account which receives this package is defined by theCurrentStorageAccountNameproperty of the current subscription. In the case where this isnulland a package upload is required, an exception is thrown. However, if the package is already uploaded, then the value ofCurrentStorageAccountNameis irrelevant.New-AzureDeployment, however, always checks whetherCurrentStorageAccountNameisnullbefore executing any code, and thus, even if the package is already uploaded to storage, it will throw an exception if this field isnull.This change makes the behavior of
New-AzureDeploymentconsistent with that ofSet-AzureDeployment- that is, it will only throw an exception whenCurrentStorageAccountNameisnullif the package needs to be uploaded.redmond\rylewell