Skip to content

Batch cert cmdlets (not for 0.9.9 release)#1079

Merged
ogail merged 4 commits intoAzure:devfrom
jasper-schneider:batchCerts
Oct 13, 2015
Merged

Batch cert cmdlets (not for 0.9.9 release)#1079
ogail merged 4 commits intoAzure:devfrom
jasper-schneider:batchCerts

Conversation

@jasper-schneider
Copy link
Copy Markdown
Contributor

@jasper-schneider jasper-schneider commented Oct 7, 2015

New cmdlets for working with Batch certs.
I'm not aiming for the 0.9.9 release due tomorrow. The next release is fine.

@azurecla
Copy link
Copy Markdown

azurecla commented Oct 7, 2015

Hi @jasper-schneider, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (jaschnei). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

ogail
ogail reviewed Oct 8, 2015
View reviewed changes
...ceManager/AzureBatch/Commands.Batch/Models.Generated/PSJobReleaseTaskExecutionInformation.cs
Copy link
Copy Markdown
Contributor

@ogail ogail Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: better to have on one line

public System.DateTime? EndTime { get { return this.omObject.EndTime; } }

Copy link
Copy Markdown
Contributor Author

@jasper-schneider jasper-schneider Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is autogenerated. I can see if there's a flag for line spacing preferences, but I'm not sure what CodeDom offers.

Copy link
Copy Markdown
Contributor Author

@jasper-schneider jasper-schneider Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not really seeing any options for output formatting when defining properties: https://msdn.microsoft.com/en-us/library/system.codedom.codememberproperty%28v=vs.110%29.aspx

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Oct 12, 2015

@azuresdkci retest this please

ogail added a commit that referenced this pull request Oct 13, 2015
@ogail
Merge pull request #1079 from jasper-schneider/batchCerts
ac71d7f 
Batch cert cmdlets (not for 0.9.9 release)
@ogail ogail merged commit ac71d7f into Azure:dev Oct 13, 2015
@jasper-schneider jasper-schneider deleted the batchCerts branch October 23, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasper-schneider @azurecla @markcowl @ogail