Pull request overview

This PR fixes issue #6391 by correcting how boolean flags are passed to the GitHub CLI when creating releases. The previous implementation incorrectly passed boolean flags with values (e.g., --prerelease true), but the GitHub CLI expects boolean flags to be passed without values (e.g., --prerelease). The PR also includes an unrelated improvement to ensure binary file executability after copying.

Key Changes:

• Fixed boolean flag handling in GitHub release creation to pass flags without values
• Added execute permissions to copied extension binaries to ensure they are executable

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

func (gh *GitHubCli) CreateRelease(cwd string, tagName string, opts map[string]string, assets []string) (*Release, error) {
	args := []string{"release", "create", tagName}

	// Define boolean flags that should be added without values
	booleanFlags := map[string]bool{"prerelease": true, "draft": true}

	// Add optional arguments (skip boolean flags)
	for key, value := range opts {
		if value != "" && !booleanFlags[key] {
			args = append(args, fmt.Sprintf("--%s", key), value)
		}
	}

	// Add boolean flags (without values)
	for flag := range booleanFlags {
		if value, ok := opts[flag]; ok && value == "true" {
			args = append(args, fmt.Sprintf("--%s", flag))
		}
	}