[WIP] network experiment by zikalino · Pull Request #996 · Azure/azure-cli-extensions

zikalino · 2019-10-14T02:41:33Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

azuresdkci · 2019-10-14T02:41:56Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Azure/azure-cli-extensions.git@network-experiment#subdirectory=src/$EXT&egg=$EXT"

…li-extensions into network-experiment

Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com>

Diego-Perez-Botero · 2019-10-25T06:13:57Z

src/internet-analyzer/azext_internet_analyzer/_params.py

+        c.argument('endpoint_a_endpoint', id_part=None, help='The URL of the control endpoint in <hostname>[/<custom-path>] format (e.g., www.contoso.com or www.contoso.com/some/path/to/trans.gif). Must support HTTPS. If an object path isn\'t specified explicitly, Internet Analyzer will use "/apc/trans.gif" as the object path by default, which is where the preconfigured endpoints are hosting the one-pixel image.')
+        c.argument('endpoint_b_name', id_part=None, help='The name of the other endpoint')
+        c.argument('endpoint_b_endpoint', id_part=None, help='The URL of the other endpoint in <hostname>[/<custom-path>] format (e.g., www.contoso.com or www.contoso.com/some/path/to/trans.gif). Must support HTTPS. If an object path isn\'t specified explicitly, Internet Analyzer will use "/apc/trans.gif" as the object path by default, which is where the preconfigured endpoints are hosting the one-pixel image.')
+        c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')


Suggested change

c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')

c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the test')

Diego-Perez-Botero · 2019-10-25T06:14:10Z

src/internet-analyzer/azext_internet_analyzer/_params.py

+        c.argument('name', id_part=None, help='The name of the Internet Analyzer profile to be updated')
+        c.argument('location', arg_type=get_location_type(self.cli_ctx))
+        c.argument('tags', tags_type)
+        c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')


Suggested change

c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')

c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the test')

Diego-Perez-Botero · 2019-10-25T06:14:20Z

src/internet-analyzer/azext_internet_analyzer/_params.py

+        c.argument('name', id_part=None, help='The name of the Internet Analyzer profile to be created')
+        c.argument('location', arg_type=get_location_type(self.cli_ctx))
+        c.argument('tags', tags_type)
+        c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')


Suggested change

c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')

c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the test')

mmyyrroonn

As the RC1 version, LGTM. We can refine it later.

Diego-Perez-Botero · 2019-10-25T06:16:27Z

src/internet-analyzer/azext_internet_analyzer/_help.py

+      - name: Creates a test
+        text: |-
+               az internet-analyzer test create --resource-group "rg1" --profile-name "Profile1" --name \\
+               "Experiment1" --description "this is my first experiment!" --endpoint-a-name "endpoint A" \\


Suggested change

"Experiment1" --description "this is my first experiment!" --endpoint-a-name "endpoint A" \\

"test1" --description "this is my first test!" --endpoint-a-name "endpoint A" \\

Diego-Perez-Botero · 2019-10-25T06:16:38Z

src/internet-analyzer/azext_internet_analyzer/_help.py

+      - name: Updates a test
+        text: |-
+               az internet-analyzer test update --resource-group "rg1" --profile-name "Profile1" --name \\
+               "Experiment1" --description "string" --enabled-state "Enabled"


Suggested change

"Experiment1" --description "string" --enabled-state "Enabled"

"test1" --description "string" --enabled-state "Enabled"

Diego-Perez-Botero · 2019-10-25T06:17:09Z

src/internet-analyzer/azext_internet_analyzer/_help.py

+      - name: Deletes a test
+        text: |-
+               az internet-analyzer test delete --resource-group "rg1" --profile-name "Profile1" --name \\
+               "Experiment1"


Suggested change

"Experiment1"

"test1"

Diego-Perez-Botero · 2019-10-25T06:20:28Z

Just added a few minor comments. Other than those, LGTM!

Diego-Perez-Botero · 2019-10-25T06:22:38Z

Nit-picky comment: PR title should be "internet analyzer" instead of "network experiment" :P

zikalino · 2019-10-25T06:26:54Z

@Diego-Perez-Botero too late :-) next one will have correct naming

Diego-Perez-Botero · 2019-10-25T06:32:10Z

@zikalino no big deal ;)

* adding autogenerated network experiment * fixed one problem * more network experiment fixes * further fixes * further fixes * adding vendored sdk as we need frontdoor experiment * networkexperiment -> frontdoor * additional parameter in test * additional parameter in example * upgraded network experiment * updated endpoint parameter names * profiles -> profile * autogenerated fixes * more sanity fixes * fixed sanity in init * fixed warnings * one more * too many blank lines * added codeowner * init in vendored sdks * renamed to network-analyzer * fixed filenames * more fixes * final rename fixes * adding list of preconfigured endpoints * fixed several generator mistakes * more ad-hoc fixes * changed network experiment structure * list profiles * fix * another fix * latency and timeseries * fix * removed unnecessary * updated scorecard things * Update src/internet-analyzer/azext_internet_analyzer/_help.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_params.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * fixed several issues * one more fix * and removed one more unnecessary thing * changed codeowner * added readme * Update src/internet-analyzer/setup.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * added hack for paging * profile name * stupid mistake * Update src/internet-analyzer/azext_internet_analyzer/_help.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Update src/internet-analyzer/azext_internet_analyzer/_help.py Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * Apply suggestions from code review Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com> * fix * additional fix * fix * one more

Zim Kalinowski added 6 commits October 14, 2019 10:26

adding autogenerated network experiment

c074627

fixed one problem

ddf3d0f

more network experiment fixes

48b6701

further fixes

40d4518

further fixes

6167b86

Merge branch 'master' into network-experiment

7d806b0

Zim Kalinowski added 23 commits October 14, 2019 10:49

adding vendored sdk as we need frontdoor experiment

5ce1068

Merge branch 'network-experiment' of https://github.com/Azure/azure-c…

9b773c5

…li-extensions into network-experiment

networkexperiment -> frontdoor

0b13f63

additional parameter in test

484633a

additional parameter in example

be2ddd1

upgraded network experiment

7430347

Merge branch 'master' into network-experiment

2fb51e0

updated endpoint parameter names

5413330

Merge branch 'network-experiment' of https://github.com/Azure/azure-c…

4beebea

…li-extensions into network-experiment

profiles -> profile

34f16d3

autogenerated fixes

96e2158

Merge branch 'master' into network-experiment

57f6020

more sanity fixes

bdf225f

fixed sanity in init

ec203fd

fixed warnings

f79e714

one more

825ee05

too many blank lines

766fba5

added codeowner

270d12f

init in vendored sdks

7a7a95b

renamed to network-analyzer

ef9b6a2

fixed filenames

13bfb03

more fixes

8891e1f

final rename fixes

5c19e89

Zim Kalinowski and others added 14 commits October 25, 2019 04:45

and removed one more unnecessary thing

d95e6e6

changed codeowner

708d0d6

added readme

ff229fb

Update src/internet-analyzer/setup.py

f6b0373

Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com>

added hack for paging

f377f17

profile name

6865325

stupid mistake

ed348aa

Update src/internet-analyzer/azext_internet_analyzer/_help.py

204bd2b

Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com>

Update src/internet-analyzer/azext_internet_analyzer/_help.py

0cb3048

Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com>

Apply suggestions from code review

0c2da5d

Co-Authored-By: Diego Perez Botero <dibotero@microsoft.com>

fix

dd5dd76

additional fix

cb2a31a

fix

8aa7bd4

one more

08954b6

Diego-Perez-Botero reviewed Oct 25, 2019

View reviewed changes

mmyyrroonn approved these changes Oct 25, 2019

View reviewed changes

Diego-Perez-Botero reviewed Oct 25, 2019

View reviewed changes

Diego-Perez-Botero approved these changes Oct 25, 2019

View reviewed changes

zikalino merged commit 305e933 into master Oct 25, 2019

zikalino deleted the network-experiment branch October 25, 2019 06:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] network experiment#996

[WIP] network experiment#996
zikalino merged 79 commits intomasterfrom
network-experiment

zikalino commented Oct 14, 2019

Uh oh!

azuresdkci commented Oct 14, 2019

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Uh oh!

mmyyrroonn left a comment

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Uh oh!

Diego-Perez-Botero commented Oct 25, 2019

Uh oh!

Diego-Perez-Botero commented Oct 25, 2019

Uh oh!

zikalino commented Oct 25, 2019

Uh oh!

Diego-Perez-Botero commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the Experiment')
	c.argument('enabled_state', arg_type=get_enum_type(['Enabled', 'Disabled']), id_part=None, help='The state of the test')

	"Experiment1" --description "this is my first experiment!" --endpoint-a-name "endpoint A" \\
	"test1" --description "this is my first test!" --endpoint-a-name "endpoint A" \\

	"Experiment1" --description "string" --enabled-state "Enabled"
	"test1" --description "string" --enabled-state "Enabled"

Conversation

zikalino commented Oct 14, 2019

General Guidelines

Uh oh!

azuresdkci commented Oct 14, 2019

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

mmyyrroonn left a comment

Choose a reason for hiding this comment

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

Diego-Perez-Botero Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

Diego-Perez-Botero commented Oct 25, 2019

Uh oh!

Diego-Perez-Botero commented Oct 25, 2019

Uh oh!

zikalino commented Oct 25, 2019

Uh oh!

Diego-Perez-Botero commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants